From: Xi Ruoyao <xry111@xry111.site>
To: Jonathan Wakely <jwakely.gcc@gmail.com>, Peng Fan <fanpeng@loongson.cn>
Cc: libstdc++@gcc.gnu.org, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] LoongArch: Add libstdc++ check-abi support.
Date: Sat, 18 Nov 2023 16:55:24 +0800 [thread overview]
Message-ID: <cc450d822be35c7a42443a60ac723c7e4dc81ae2.camel@xry111.site> (raw)
In-Reply-To: <CAH6eHdQ+tOc96Qysg+9t2wKzAza_nT1Ra-U5jpCUKZDcw-2_Vg@mail.gmail.com>
On Sat, 2023-11-18 at 08:43 +0000, Jonathan Wakely wrote:
> Hi,
>
> Libstdc++ patches need to be CC'd to the gcc-patches list as well.
>
> On Wed, 8 Nov 2023 at 10:26, Peng Fan <fanpeng@loongson.cn> wrote:
> >
> > libstdc++-v3:
> >
> > * configure.host: Add abi_baseline_pair for LoongArch.
> > * config/abi/post/riscv64-linux-gnu: New directory.
> > * config/abi/post/riscv64-linux-gnu/baseline_symbols.txt: New file.
>
> Looks like the wrong filename here.
Try "git gcc-verify ${sha}" (you need to configure the local git repo
with contrib/gcc-git-customization.sh first), it will detect such issues
before submission.
> > Signed-off-by: Peng Fan <fanpeng@loongson.cn>
This should be unneeded because Loongson company should have already
signed a FSF copyright assignment.
/* snip */
>
> > +TLS:8:_ZSt11__once_call
> > +TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
> > +TLS:8:_ZSt15__once_callable
> > +TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>
> Does this target support TLS unconditionally? These TLS symbols are
> not included in the baseline symbols for x86_64-pc-linux-gnu, for
> example.
A hardware register is used as TP on this target. But anyway TLS may be
disabled via --disable-tls, though I don't know it this configuration
really works on loongarch64-linux-gnu (nobody have really tested it, I
guess).
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
prev parent reply other threads:[~2023-11-18 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 10:25 Peng Fan
2023-11-18 8:43 ` Jonathan Wakely
2023-11-18 8:55 ` Xi Ruoyao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc450d822be35c7a42443a60ac723c7e4dc81ae2.camel@xry111.site \
--to=xry111@xry111.site \
--cc=fanpeng@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).