From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 456E23858C62; Mon, 28 Nov 2022 20:44:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 456E23858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x431.google.com with SMTP id q7so18008867wrr.8; Mon, 28 Nov 2022 12:44:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=GvU0BXrJ3kkkDHgvBi5ie9yngcHBWq4Mx9fj5645RcY=; b=klgk0RrDKYYjn2PLiC6G2pwRxoTBSSYWyqszb4P5N4gnZc+/jADYp6V8rRMlIVHpAm xPWSOOabvEZpWRmNJZAf7EpBvxPc5mqZVVTXgsGqREpM9l+0tNipWGIAnBqJoAaA6c9f f4VjDm9ysn/otby1rJ08AZ557IS2O50sztiwuQLMGiVEs+7vCyQktCUBf4JCA2H5DkDH M6Mp71uwTvZQzABWbtZr3aNKqE1RmSyNaZZ5HRqFD5+gcAWvuFlPxcGRRw/5f2+jiPt4 VE/Pr7J7lND3E7rIpTcVsGwVOBK/v6+lSAGWjs1SQbxvJQOa6O5tBTCuRLxrg6dY1MN2 JWxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GvU0BXrJ3kkkDHgvBi5ie9yngcHBWq4Mx9fj5645RcY=; b=Ljo1lMta/GGGvJADYmtOTUPiMR9sKIAwCUlOrFCVGuvEsYnje8LQCjh2uxaiqB141B d6yqCb9l7dxBq4PcySgnYBzatxUjjVGJQesKUDKOAorJ+9FIBu8rEZ4bQxqlbTCkmotI U6CyQqDUI7Ypd3bvd8kaYPqAFjSN5+nkjvQZ8LhhLDm+2tEEwxi1tbohIHYndgYTJYo2 hwfpjP7UM9jssyczIb0N7HYBIfwLcACI1R28b8vKRquRf3frpsplTpCGmCX4m45sh8/f BBu9jxVbHTE+gA6emyWxdFHNsGG7U39GQWBK/MP58OSl0LFWV3wwIRf0kOairW4ure2N yhfQ== X-Gm-Message-State: ANoB5pkXHSz6t700ebZryxFXSkutqs4nY6HSngmc8bJk3ItGsQO/hthS MqCjPkw9JJ8wYwXa5eAxibk= X-Google-Smtp-Source: AA0mqf4znRWTKq8ojtQmu53ZiPMwTti7V7qQW1qLhn51aaGJ1NiQucwQ1uT59ToBQZOtVFamRImSXQ== X-Received: by 2002:adf:fb0e:0:b0:241:87cb:6e0c with SMTP id c14-20020adffb0e000000b0024187cb6e0cmr22342459wrr.166.1669668255896; Mon, 28 Nov 2022 12:44:15 -0800 (PST) Received: from ?IPV6:2a01:e0a:1dc:b1c0:b0a:7974:ee38:5396? ([2a01:e0a:1dc:b1c0:b0a:7974:ee38:5396]) by smtp.googlemail.com with ESMTPSA id b17-20020a5d4b91000000b0024207478de3sm9238982wrt.93.2022.11.28.12.44.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 12:44:14 -0800 (PST) Content-Type: multipart/mixed; boundary="------------YPTIu2uIM6QD2HFmDDg5n0W7" Message-ID: Date: Mon, 28 Nov 2022 21:44:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Adapt to_chars/from_chars symbols To: Jonathan Wakely Cc: "libstdc++@gcc.gnu.org" , gcc-patches References: Content-Language: fr From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------YPTIu2uIM6QD2HFmDDg5n0W7 Content-Type: multipart/alternative; boundary="------------TlA0AOs0Cql8DUDIf3BAvXBY" --------------TlA0AOs0Cql8DUDIf3BAvXBY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/11/22 19:35, Jonathan Wakely wrote: > > > On Mon, 28 Nov 2022 at 06:07, François Dumont via Libstdc++ > > wrote: > > This patch is fixing those tests: > > 20_util/to_chars/float128_c++23.cc > std/format/formatter/requirements.cc > std/format/functions/format.cc > std/format/functions/format_to_n.cc > std/format/functions/size.cc > std/format/functions/vformat_to.cc > std/format/string.cc > > Note that symbols used in for __ibm128 and __iee128 are > untested. > > > We don't need to do this for those symbols, the ALT128 config is > incompatible with versioned namespace. If you're using the versioned > namespace, you don't need backwards compatibility with the old long > double ABI. > > > Here is the simplified patch then.     libstdc++: [_GLIBCXX_INLINE_VERSION] Add to_chars/from_chars symbols export     libstdc++-v3/ChangeLog             * include/std/format [_GLIBCXX_INLINE_VERSION](to_chars): Adapt __asm symbol             specifications.             * config/abi/pre/gnu-versioned-namespace.ver: Add to_chars/from_chars symbols             export. Ok to commit ? François --------------TlA0AOs0Cql8DUDIf3BAvXBY-- --------------YPTIu2uIM6QD2HFmDDg5n0W7 Content-Type: text/x-patch; charset=UTF-8; name="symbols.patch" Content-Disposition: attachment; filename="symbols.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9jb25maWcvYWJpL3ByZS9nbnUt dmVyc2lvbmVkLW5hbWVzcGFjZS52ZXIgYi9saWJzdGRjKystdjMvY29uZmln L2FiaS9wcmUvZ251LXZlcnNpb25lZC1uYW1lc3BhY2UudmVyCmluZGV4IDA2 Y2NhYTgwYTU4Li43ZmM4MTUxNDgwOCAxMDA2NDQKLS0tIGEvbGlic3RkYysr LXYzL2NvbmZpZy9hYmkvcHJlL2dudS12ZXJzaW9uZWQtbmFtZXNwYWNlLnZl cgorKysgYi9saWJzdGRjKystdjMvY29uZmlnL2FiaS9wcmUvZ251LXZlcnNp b25lZC1uYW1lc3BhY2UudmVyCkBAIC0xNDIsNiArMTQyLDEyIEBAIEdMSUJD WFhfOC4wIHsKICAgICBfWk4xNF9fZ251X3BhcmFsbGVsOV9TZXR0aW5nczNn ZXRFdjsKICAgICBfWk4xNF9fZ251X3BhcmFsbGVsOV9TZXR0aW5nczNzZXRF UlMwXzsKIAorICAgICMgdG9fY2hhcnMvZnJvbV9jaGFycyBfRmxvYXQxMjgK KyAgICBfWk5TdDNfXzg4dG9fY2hhcnNFUGNTMF9ERjEyOF87CisgICAgX1pO U3QzX184OHRvX2NoYXJzRVBjUzBfREYxMjhfTlNfMTJjaGFyc19mb3JtYXRF OworICAgIF9aTlN0M19fODh0b19jaGFyc0VQY1MwX0RGMTI4X05TXzEyY2hh cnNfZm9ybWF0RWk7CisgICAgX1pOU3QzX184MTBmcm9tX2NoYXJzRVBLY1Mx X1JERjEyOF9OU18xMmNoYXJzX2Zvcm1hdEU7CisKICAgbG9jYWw6CiAgICAg KjsKIH07CmRpZmYgLS1naXQgYS9saWJzdGRjKystdjMvaW5jbHVkZS9zdGQv Zm9ybWF0IGIvbGlic3RkYysrLXYzL2luY2x1ZGUvc3RkL2Zvcm1hdAppbmRl eCAyM2ZmYmRhYmVkOC4uZmI3YTAyY2VjNTcgMTAwNjQ0Ci0tLSBhL2xpYnN0 ZGMrKy12My9pbmNsdWRlL3N0ZC9mb3JtYXQKKysrIGIvbGlic3RkYysrLXYz L2luY2x1ZGUvc3RkL2Zvcm1hdApAQCAtMTI4OCwxNSArMTI4OCwyNyBAQCBu YW1lc3BhY2UgX19mb3JtYXQKICAgLy8gTWFrZSB0aGVtIGF2YWlsYWJsZSBh cyBzdGQ6Ol9fZm9ybWF0Ojp0b19jaGFycy4KICAgdG9fY2hhcnNfcmVzdWx0 CiAgIHRvX2NoYXJzKGNoYXIqLCBjaGFyKiwgX0Zsb2F0MTI4KSBub2V4Y2Vw dAorIyAgaWYgX0dMSUJDWFhfSU5MSU5FX1ZFUlNJT04KKyAgICBfX2FzbSgi X1pOU3QzX184OHRvX2NoYXJzRVBjUzBfREYxMjhfIik7CisjICBlbHNlCiAg ICAgX19hc20oIl9aU3Q4dG9fY2hhcnNQY1NfREYxMjhfIik7CisjICBlbmRp ZgogCiAgIHRvX2NoYXJzX3Jlc3VsdAogICB0b19jaGFycyhjaGFyKiwgY2hh ciosIF9GbG9hdDEyOCwgY2hhcnNfZm9ybWF0KSBub2V4Y2VwdAorIyAgaWYg X0dMSUJDWFhfSU5MSU5FX1ZFUlNJT04KKyAgICBfX2FzbSgiX1pOU3QzX184 OHRvX2NoYXJzRVBjUzBfREYxMjhfTlNfMTJjaGFyc19mb3JtYXRFIik7Cisj ICBlbHNlCiAgICAgX19hc20oIl9aU3Q4dG9fY2hhcnNQY1NfREYxMjhfU3Qx MmNoYXJzX2Zvcm1hdCIpOworIyAgZW5kaWYKIAogICB0b19jaGFyc19yZXN1 bHQKICAgdG9fY2hhcnMoY2hhciosIGNoYXIqLCBfRmxvYXQxMjgsIGNoYXJz X2Zvcm1hdCwgaW50KSBub2V4Y2VwdAorIyAgaWYgX0dMSUJDWFhfSU5MSU5F X1ZFUlNJT04KKyAgICBfX2FzbSgiX1pOU3QzX184OHRvX2NoYXJzRVBjUzBf REYxMjhfTlNfMTJjaGFyc19mb3JtYXRFaSIpOworIyAgZWxzZQogICAgIF9f YXNtKCJfWlN0OHRvX2NoYXJzUGNTX0RGMTI4X1N0MTJjaGFyc19mb3JtYXRp Iik7CisjICBlbmRpZgogIyBlbmRpZgogI2VuZGlmCiAK --------------YPTIu2uIM6QD2HFmDDg5n0W7--