From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 240FE3858D33; Wed, 8 Nov 2023 05:39:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 240FE3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 240FE3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699421968; cv=none; b=bO0dovVt3Uue/tSwPCEPNiXLPQ3YLInQwIezWF6Ldq0CZ14aPABwZRCVUyCCaAJTsMkIkyw6Oc8TUv2i2Ng8SkyieuGcWDDMHmei7y3z40jLMmlUnCL8Ib3uhouy3GBRyaoOmviPmWBIUHQHlx5eKzhdWMSxte1DDmtOep5T4zM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699421968; c=relaxed/simple; bh=IxyMupokYy+kdf/eJpE6l8uWaapfaa+aW87VtbnqtwI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=suH7TMXgl9fqH3fpGaOQic5Ftdq7cbtRUZCpbnWPdDqKNwgikurXBPw70ukTjM6Hr7ljxAoDPavPDlfuNdW0VIo0VpVcrYNosG9eCYxrNIBO4vzKrXFRi2S6u+moXAnKAZSixAf3SmtYsGbGCHrJ3rLNRbN5bVxrTaZ5WlFSebM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2c5210a1515so89145691fa.0; Tue, 07 Nov 2023 21:39:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699421965; x=1700026765; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WXR8fSNOiJXf2XOAHfv6+N2c0Vtk+GKPZUBAWVBNB30=; b=XLh5ZJ5UUSuI061sn/JWa/4uSZdMWJB8z3/qoscjxVKNQF2ndzidCkiIktRYp3Hnvg zjZ2bYMKLgqbRAphZEdLi7mvY/PDohxPKe+gq6fxCFtJdnBishQ3lAvu+Q7UqE9GJf1q 4wJIkMbtKlHHV21IL3IOlnKeFYAGk+X/7Sqgo3hyeMaMOxiXyPoZcQW49B8cFYCLSaJr 6LWi7F/F6grxgo7bvAZZh1AK9FI+Pna3uqS9kRJ6jvX1x+UPjtPMv1FeoHytk5XPUiKa Rf35LPcmadFdK9V3w2P0HQxZFyT3QYYiGP2kKnZbS8R088L9tY7BUkieIbk7Fx1sWgbl 8Kyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699421965; x=1700026765; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WXR8fSNOiJXf2XOAHfv6+N2c0Vtk+GKPZUBAWVBNB30=; b=A+i7eb8mYDFWoYRsgDO6IXEwPGLLouGKDpK5MJnjByjiRKiRb4+xraabsz1jg2oTYM Q9oTd0tZU2geL+7VeYpv4NnHxFvxBcetmVdRJ1dtANUVKDDXqc7frhExU3InqJB48KwQ /IndB3qXuRhP7Wy5cE1s4CK5jw6RZqI3OqQlVbfmBzkviY8wX/nkfS2CaCbuP684a+ar SioxFczYYxm0vZpGqKZTmG5t7bCsu3W2MWr89jdKRS5owr7dTv8TgYTCYuN+itwY7bRl wFBb4xrqMcdNVUaTzarYAAk+XqS36KaWGmps7wKmkxoNd4Yhv9VuXw+b87UQPXmL6qeR a8Ww== X-Gm-Message-State: AOJu0YxosGQf5jyY0goTo5x7Sk0daET+hg7Sa9fq6MNKOPyeb+HArTZB 9jgDId8YqrBpRjHL4r/xHtE= X-Google-Smtp-Source: AGHT+IHKEOd4M7VPNDh/pyEtoM4SK3W9KeKyirPlMTIEZWWNrYPgcniCCZ0h6hq64WzUl9wNCfWZdQ== X-Received: by 2002:a2e:6a0e:0:b0:2c5:1388:e369 with SMTP id f14-20020a2e6a0e000000b002c51388e369mr899494ljc.43.1699421964768; Tue, 07 Nov 2023 21:39:24 -0800 (PST) Received: from [10.37.0.66] ([89.207.171.104]) by smtp.gmail.com with ESMTPSA id d8-20020a05600c34c800b0040770ec2c19sm18360391wmq.10.2023.11.07.21.39.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Nov 2023 21:39:24 -0800 (PST) Message-ID: Date: Wed, 8 Nov 2023 06:39:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][_Hashtable] Add missing destructor call To: Jonathan Wakely Cc: libstdc++ , gcc-patches References: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07/11/2023 00:28, Jonathan Wakely wrote: > On Mon, 6 Nov 2023 at 21:39, François Dumont wrote: >> Noticed looking for other occasion to replace __try/__catch with RAII >> helper. >> >> libstdc++: [_Hashtable] Add missing node destructor call >> >> libstdc++-v3/ChangeLog: >> >> * include/bits/hashtable_policy.h >> (_Hashtable_alloc<>::_M_allocate_node): Add missing call to >> node destructor >> on construct exception. >> >> Tested under Linux x64, ok to commit ? > OK. > > Is this missing on any branches too? Clearly all maintained branches. > I don't think it's actually a problem, since it's a trivial destructor anyway. Yes, me neither, I was only thinking about sanity checker tools when doing this so no plan for backports.