From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 500803858428 for ; Tue, 30 Apr 2024 20:56:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 500803858428 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 500803858428 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510597; cv=none; b=U1s6r3Y6CiwW/MzXkr9/1zXgNAXMGmxTnFzyPJ/po6h9Algz7ZufRbE96uZsDg0EDMVgBN8iDrJFoznq28fooAtqFTiy0h93TSH5jd1qb1EuYe+dYG2KOofZu9ZMvhmzZ8B0UPyveGntdznx0DU1BN6pn0kQ8FKy1F+w1a5nNjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510597; c=relaxed/simple; bh=XBFt9zLMJ3JwKc0b8Dfj+lNS5q98tO+PiIVNvpwiKz8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=G1+vb6toQwPnqsquiBuq2DTHstEDWjPpt6YCNgQamEeE/BkJnqj4xLhvc0WFZOHEXTNWWae6Ai/0D+Jeq8PoXxCJ/IZJ1SWK3uUXytYpkIhsQo4WzWTF0jgTWJWIXYdt36FJFsJu6GsIbGETt468XaWE6rL2bBqhp2Yb76h1GL8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714510595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cX93rFUsntsSYDnYv3eGbL3g/BzeGvlv8gS8ei7Nmn4=; b=gUVXusGEhClTQS2QSA8Po7f32FeSz+v5JcqXkI0eKTtHdX84aQOX5QDeeURb76auCYoQy7 OtoobGash5+emckl2+qdEUNz3G4gl+cgULoufgIWB+asPt9FNX8+gJA7lcU6TgPhsgtPhc DQEo2gdFMdCjq1iGFChIpc21skZm9wU= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-kGWSVsagPL6rZwb9OafqZA-1; Tue, 30 Apr 2024 16:56:33 -0400 X-MC-Unique: kGWSVsagPL6rZwb9OafqZA-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-43a6d1e7708so71597101cf.1 for ; Tue, 30 Apr 2024 13:56:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714510592; x=1715115392; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cX93rFUsntsSYDnYv3eGbL3g/BzeGvlv8gS8ei7Nmn4=; b=Nfqt+33J4hwCCn+PNxxyBhDLchjN/bqgKqk9evKTBmow0883B7GQn0F8297PzvpAvJ hunnrD3vLnIPYSTRKt6FHhUmYcbN1PzXdbVc1ySlSVHtUGIzR+wENsatj+PIgD91h4kP X7GOzzs/R2PakFmUZ1QMfX7iFXRgZSvQ1CqxRBet9arczHEuVRyfOVVVILA8Klccw7Bk P4e07fmTxmDJoE7pw2l1pr+NkwvKUwLsYzLMW0WkcSli+jFUh+pllQc7jLHm5APbMZE3 q/6l6mCltBGUrj9WXjnno1IVqXyE2+9GNgIW3lZO9aRUraBcsGrnDISN5uZHh+k4K1sX b/HA== X-Gm-Message-State: AOJu0Yxf+emxSLmJx9h+tFSVL6m5yJJBjMiGJ8ZocF0IRbmkgmbMLGsB 27OmzmpadqexvsP4oaqGU0c0M63nbxlYyywtaaScD9GngWX6+JbW3Bn7+mmVwzY6K2OgpZ+3o57 oSQMoeRt4HZbfmhdJc7dgfmbCMr+NiC3+fkqdDfsvjZOw5qsyhnBF X-Received: by 2002:a05:622a:8b:b0:43a:cfc1:7f28 with SMTP id o11-20020a05622a008b00b0043acfc17f28mr451628qtw.16.1714510592384; Tue, 30 Apr 2024 13:56:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2EsFEY49KvIi+SY9N48TlsdwCq0aU6y6+3/gcHIVsWTp3juXoZgv29xV13CSnKTMECfQ8iA== X-Received: by 2002:a05:622a:8b:b0:43a:cfc1:7f28 with SMTP id o11-20020a05622a008b00b0043acfc17f28mr451617qtw.16.1714510592116; Tue, 30 Apr 2024 13:56:32 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id dn16-20020a05622a471000b00436cd19d996sm11675828qtb.87.2024.04.30.13.56.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 13:56:31 -0700 (PDT) Message-ID: Date: Tue, 30 Apr 2024 16:56:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 05/26] c++: Implement __is_pointer built-in trait To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20240221093616.4001742-1-kmatsui@gcc.gnu.org> <20240228192843.188979-1-kmatsui@gcc.gnu.org> <20240228192843.188979-6-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240228192843.188979-6-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/24 11:26, Ken Matsui wrote: > This patch implements built-in trait for std::is_pointer. OK. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_pointer. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_POINTER. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_pointer. > * g++.dg/ext/is_pointer.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/constraint.cc | 3 ++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 ++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 ++ > gcc/testsuite/g++.dg/ext/is_pointer.C | 51 ++++++++++++++++++++++++ > 5 files changed, 62 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_pointer.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index 9a7a12629e7..244070d93c2 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3828,6 +3828,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_POD: > inform (loc, " %qT is not a POD type", t1); > break; > + case CPTK_IS_POINTER: > + inform (loc, " %qT is not a pointer", t1); > + break; > case CPTK_IS_POLYMORPHIC: > inform (loc, " %qT is not a polymorphic type", t1); > break; > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index e9347453829..18e2d0f3480 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_NOTHROW_CONVERTIBLE, "__is_nothrow_convertible", 2) > DEFTRAIT_EXPR (IS_OBJECT, "__is_object", 1) > DEFTRAIT_EXPR (IS_POINTER_INTERCONVERTIBLE_BASE_OF, "__is_pointer_interconvertible_base_of", 2) > DEFTRAIT_EXPR (IS_POD, "__is_pod", 1) > +DEFTRAIT_EXPR (IS_POINTER, "__is_pointer", 1) > DEFTRAIT_EXPR (IS_POLYMORPHIC, "__is_polymorphic", 1) > DEFTRAIT_EXPR (IS_REFERENCE, "__is_reference", 1) > DEFTRAIT_EXPR (IS_SAME, "__is_same", 2) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 41c25f43d27..9dcdb06191a 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12502,6 +12502,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_POD: > return pod_type_p (type1); > > + case CPTK_IS_POINTER: > + return TYPE_PTR_P (type1); > + > case CPTK_IS_POLYMORPHIC: > return CLASS_TYPE_P (type1) && TYPE_POLYMORPHIC_P (type1); > > @@ -12701,6 +12704,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_MEMBER_OBJECT_POINTER: > case CPTK_IS_MEMBER_POINTER: > case CPTK_IS_OBJECT: > + case CPTK_IS_POINTER: > case CPTK_IS_REFERENCE: > case CPTK_IS_SAME: > case CPTK_IS_SCOPED_ENUM: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index b2e2f2f694d..96b7a89e4f1 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -125,6 +125,9 @@ > #if !__has_builtin (__is_pod) > # error "__has_builtin (__is_pod) failed" > #endif > +#if !__has_builtin (__is_pointer) > +# error "__has_builtin (__is_pointer) failed" > +#endif > #if !__has_builtin (__is_polymorphic) > # error "__has_builtin (__is_polymorphic) failed" > #endif > diff --git a/gcc/testsuite/g++.dg/ext/is_pointer.C b/gcc/testsuite/g++.dg/ext/is_pointer.C > new file mode 100644 > index 00000000000..d6e39565950 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_pointer.C > @@ -0,0 +1,51 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +SA(!__is_pointer(int)); > +SA(__is_pointer(int*)); > +SA(__is_pointer(int**)); > + > +SA(__is_pointer(const int*)); > +SA(__is_pointer(const int**)); > +SA(__is_pointer(int* const)); > +SA(__is_pointer(int** const)); > +SA(__is_pointer(int* const* const)); > + > +SA(__is_pointer(volatile int*)); > +SA(__is_pointer(volatile int**)); > +SA(__is_pointer(int* volatile)); > +SA(__is_pointer(int** volatile)); > +SA(__is_pointer(int* volatile* volatile)); > + > +SA(__is_pointer(const volatile int*)); > +SA(__is_pointer(const volatile int**)); > +SA(__is_pointer(const int* volatile)); > +SA(__is_pointer(volatile int* const)); > +SA(__is_pointer(int* const volatile)); > +SA(__is_pointer(const int** volatile)); > +SA(__is_pointer(volatile int** const)); > +SA(__is_pointer(int** const volatile)); > +SA(__is_pointer(int* const* const volatile)); > +SA(__is_pointer(int* volatile* const volatile)); > +SA(__is_pointer(int* const volatile* const volatile)); > + > +SA(!__is_pointer(int&)); > +SA(!__is_pointer(const int&)); > +SA(!__is_pointer(volatile int&)); > +SA(!__is_pointer(const volatile int&)); > + > +SA(!__is_pointer(int&&)); > +SA(!__is_pointer(const int&&)); > +SA(!__is_pointer(volatile int&&)); > +SA(!__is_pointer(const volatile int&&)); > + > +SA(!__is_pointer(int[3])); > +SA(!__is_pointer(const int[3])); > +SA(!__is_pointer(volatile int[3])); > +SA(!__is_pointer(const volatile int[3])); > + > +SA(!__is_pointer(int(int))); > +SA(__is_pointer(int(*const)(int))); > +SA(__is_pointer(int(*volatile)(int))); > +SA(__is_pointer(int(*const volatile)(int)));