From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25845 invoked by alias); 8 Sep 2017 06:15:31 -0000 Mailing-List: contact libstdc++-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libstdc++-owner@gcc.gnu.org Received: (qmail 121042 invoked by uid 89); 8 Sep 2017 06:15:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail-wr0-f172.google.com Received: from mail-wr0-f172.google.com (HELO mail-wr0-f172.google.com) (209.85.128.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Sep 2017 06:15:14 +0000 Received: by mail-wr0-f172.google.com with SMTP id k20so2657901wre.4 for ; Thu, 07 Sep 2017 23:15:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=a6KRNMBrQ5wmnCrt1Ew7+oDsCefoKrehCvFpeCBB1LU=; b=Da+6zTubUSqEtZw6rVjxqvDXe4Ec99nwMdd4++QA8raqUkTh8k35VI7vE2ukQ/IyZv hY9OAE7/IksxaWcKHag5JI06Y+gVlVqjypUTUKj7IeBqZVOIPl2xSzQ/RCdOishTWBte vw1Ipxb2xPJsIQ4cXa/1biekR2wQjjgPIEekZ7rlDc60YVd/356V1nYYuUEzCkJiX+vU 7ZF7mLnD0LXuIqocoC6T7hCLhEMhqjY2K/hXH0ofS6NCP26wew+tnba61rX+KLgG4jXw qigKSZpARZn9GnHAvqKSESZeYUFNgKT/YH6+A5PV+0DpCl5MI46Tpz2STdM7bEaoGO9G 1hbQ== X-Gm-Message-State: AHPjjUiVA4XbdejRgA2seATekSG4PJIhiivH3HoJUo9pPnB5m2C9Rg4g ZnaGy6YfEiNuXAUl X-Google-Smtp-Source: ADKCNb7ILnh1FzusaCIKqf7RPmbsNRDWeZsIDjjtkEo54K8mZcEkCsKBmAIokpX1i77f5xgW0aTJmA== X-Received: by 10.223.177.222 with SMTP id r30mr1185357wra.128.1504851307494; Thu, 07 Sep 2017 23:15:07 -0700 (PDT) Received: from [192.168.0.23] (arf62-1-82-237-250-248.fbx.proxad.net. [82.237.250.248]) by smtp.googlemail.com with ESMTPSA id e8sm2567383wmf.12.2017.09.07.23.15.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Sep 2017 23:15:06 -0700 (PDT) Subject: Re: [PATCH] streambuf_iterator: avoid debug-dependent behaviour To: Petr Ovtchenkov Cc: libstdc++@gcc.gnu.org References: <20170901091037.GW4582@redhat.com> <86fe822c-96c0-1167-68d9-d79729f3dec5@gmail.com> <20170908084740.5afaeae3@void-ptr.info> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Message-ID: Date: Fri, 08 Sep 2017 06:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170908084740.5afaeae3@void-ptr.info> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00011.txt.bz2 On 08/09/2017 07:47, Petr Ovtchenkov wrote: > -gcc-patches > > On Thu, 7 Sep 2017 23:02:15 +0200 > François Dumont wrote: > >> + _M_c = _M_sbuf->sgetc(); >> + if (_S_at_eof(_M_c)) >> + _M_sbuf = 0; > _M_sbuf = 0; <--- Is not what I expect here. I know but I didn't say that I agree with all your patch. I only agree with your remark about current implementation being debug-dependant which I have been able to prove with a test case at the cost of a small change in the current implementation to fix another problem.