From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 7E4D83858D38; Mon, 11 Sep 2023 17:19:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E4D83858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-501cef42bc9so7691614e87.0; Mon, 11 Sep 2023 10:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694452785; x=1695057585; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5PGADe2jVwwUooC2rblfTQDnvyyLbRitZjyMs/poEXs=; b=U7qUv8XlPmJRQbu0kntKyHIxDhxlgXHQp4TT7P/vrfxRRCfs6TP8K+5gQWfvuF9sFJ qe0UQmMhBj4zYMNrMsBKxaB0lvbXbmVIh67mc8hww1FkSLpMYE0HtbF0h3fE3ly/JSm4 zYgg5eVcHUcSZWUE4RJESzQ0FNgjBAoYRDyP6ZV6wRnzEiLOb9PUMDP47zSOGLQ6u3QH G6YEtKPEMBvAVb+iyKmmMWf9VqLubcHd6cI2NeaSm8tqA1Kr+tPRlTPtN9+WciUl/Y2T vWcnZ4Daq5VyHZFaegr73tO0kGcVQr7NgnEpFeeLnOFPUymH8BbRdBTK37p/ym9Ifg98 fPfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694452785; x=1695057585; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5PGADe2jVwwUooC2rblfTQDnvyyLbRitZjyMs/poEXs=; b=V2+NNcK3AuA0eGb5Rnir5guxW3pR2XNTvu/VFAxJ5nyHeM9yvIbmc6eIiKQeDbJH9I jl5yPf1pzeaZ3aFZ2sv/aKOcU0v9aJdQlNnQeCB4wzZqfvtiB7/SauZY/VTEu1L3oLPe rOLiSlK3KUQ8MVusrkKoA+0km3CybnBPYPyyCCH85W4aAj3x+A3ATJPLa1Pmc+khvBdF 9/+X62rroDDfOPuil4l4OeYg4CgiCdclB7+KI6oW2qEoGcdquQ+0mduZwB+It0YMB6L2 4Xjt4fNGOjHRJjICE0F197yG2+XXYgyNbJMniIO0KXpg7TY3NYC/uO8o1100v1WeV2SD BkBw== X-Gm-Message-State: AOJu0YxZDGFM7Wm7i1SjVdarBrFchWIMFUJvVkNwYY40FsHddCg73vM1 VgOeeVpwGm5BhGBjwc9oNuKzn/DDTxQ= X-Google-Smtp-Source: AGHT+IEQu8uE/+the8LlM/ea463t5WhSqaQcvjSTMFJhfAPJF+0RQjA0HOr0fnuEvVAUuZY8lkj16Q== X-Received: by 2002:a2e:2c13:0:b0:2bc:df3f:7140 with SMTP id s19-20020a2e2c13000000b002bcdf3f7140mr8483214ljs.17.1694452784550; Mon, 11 Sep 2023 10:19:44 -0700 (PDT) Received: from [10.13.2.116] ([89.207.171.96]) by smtp.gmail.com with ESMTPSA id n12-20020a170906118c00b009a5f1d15642sm5643682eja.158.2023.09.11.10.19.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 10:19:44 -0700 (PDT) Message-ID: Date: Mon, 11 Sep 2023 19:19:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] [11/12/13/14 Regression] ABI break in _Hash_node_value_base since GCC 11 [PR 111050] Content-Language: en-US To: Jonathan Wakely , rs2740@gmail.com Cc: libstdc++ , gcc-patches References: From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/09/2023 13:51, Jonathan Wakely wrote: > On Sun, 10 Sept 2023 at 14:57, François Dumont via Libstdc++ > wrote: >> Following confirmation of the fix by TC here is the patch where I'm >> simply adding a 'constexpr' on _M_next(). >> >> Please let me know this ChangeLog entry is correct. I would prefer this >> patch to be assigned to 'TC' with me as co-author but I don't know how >> to do such a thing. Unless I need to change my user git identity to do so ? > Sam already explained that, but please check with Tim how he wants to > be credited, if at all. He doesn't have a copyright assignment, and > hasn't added a DCO sign-off to the patch, but it's small enough to not > need it as this is the first contribution credited to him. > > >> libstdc++: Add constexpr qualification to _Hash_node::_M_next() > What has this constexpr addition got to do with the ABI change and the > always_inline attributes? > > It certainly doesn't seem like it should be the summary line of the > git commit message. Oops, sorry, that's what I had started to do before Tim submitted anything. Here is latest version: Author: TC Date:   Wed Sep 6 19:31:55 2023 +0200     libstdc++: Force inline on _Hash_node_value_base methods to fix abi (PR111050) https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1b6f0476837205932613ddb2b3429a55c26c409d     changed _Hash_node_value_base to no longer derive from _Hash_node_base, which means     that its member functions expect _M_storage to be at a different offset. So explosions     result if an out-of-line definition is emitted for any of the member functions (say,     in a non-optimized build) and the resulting object file is then linked with code built     using older version of GCC/libstdc++.     libstdc++-v3/ChangeLog:             PR libstdc++/111050             * include/bits/hashtable_policy.h             (_Hash_node_value_base<>::_M_valptr(), _Hash_node_value_base<>::_M_v())             Add [[__gnu__::__always_inline__]].             (_Hash_node<>::_M_next()): Add constexpr.     Co-authored-by: François Dumont Ok for you TC (Tim ?) ?