public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: "François Dumont" <frs.dumont@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix <contracts>
Date: Thu, 21 Sep 2023 06:41:14 +0200	[thread overview]
Message-ID: <d7162f50-fb2d-a6b8-1d5d-fc430f900a70@gmail.com> (raw)
In-Reply-To: <520bd324-39e8-45e0-a367-3d1195c1807f@gmail.com>

Tests were successful, ok to commit ?

On 20/09/2023 19:51, François Dumont wrote:
> libstdc++: [_GLIBCXX_INLINE_VERSION] Add handle_contract_violation 
> symbol alias
>
> libstdc++-v3/ChangeLog:
>
>     * src/experimental/contract.cc
>     [_GLIBCXX_INLINE_VERSION](handle_contract_violation): Provide 
> symbol alias
>     without version namespace decoration for gcc.
>
> Here is what I'm testing eventually, ok to commit if successful ?
>
> François
>
> On 20/09/2023 11:32, Jonathan Wakely wrote:
>> On Wed, 20 Sept 2023 at 05:51, François Dumont via Libstdc++
>> <libstdc++@gcc.gnu.org> wrote:
>>> libstdc++: Remove std::constract_violation from versioned namespace
>> Spelling mistake in contract_violation, and it's not
>> std::contract_violation, it's std::experimental::contract_violation
>>
>>> GCC expects this type to be in std namespace directly.
>> Again, it's in std::experimental not in std directly.
>>
>> Will this change cause problems when including another experimental
>> header, which does put experimental below std::__8?
>>
>> I think std::__8::experimental and std::experimental will become 
>> ambiguous.
>>
>> Maybe we do want to remove the inline __8 namespace from all
>> experimental headers. That needs a bit more thought though.
>>
>>> libstdc++-v3/ChangeLog:
>>>
>>>       * include/experimental/contract:
>>>       Remove 
>>> _GLIBCXX_BEGIN_NAMESPACE_VERSION/_GLIBCXX_END_NAMESPACE_VERSION.
>> This line is too long for the changelog.
>>
>>> It does fix 29 g++.dg/contracts in gcc testsuite.
>>>
>>> Ok to commit ?
>>>
>>> François

  reply	other threads:[~2023-09-21  4:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  4:51 François Dumont
2023-09-20  9:32 ` Jonathan Wakely
2023-09-20 17:51   ` François Dumont
2023-09-21  4:41     ` François Dumont [this message]
2023-10-08 14:06       ` Iain Sandoe
2023-10-09  5:06         ` François Dumont
2023-10-09  9:23           ` Iain Sandoe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7162f50-fb2d-a6b8-1d5d-fc430f900a70@gmail.com \
    --to=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).