From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id DAC7E3858C52; Thu, 21 Sep 2023 04:41:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAC7E3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-52f3ba561d9so962703a12.1; Wed, 20 Sep 2023 21:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695271277; x=1695876077; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=YfcUvSTLjAeluMlyug41ie2E6IIvnxGKxfLMCD7tBf4=; b=Wlc1e4RahuoQYciYYTaBd6bcR9ZiAOKSLu6FRzEu1jdor4YMPEuCZqua+NlCh7eCb2 zB6nOJeFlcQSqZJZ3YURtkCd9ukCxCcZLD1L8p5q4j3CVr2RTJ7NtBWZEUiOhaKbMB7h koZtT8D+KiljrGh+dcmoxff5WhlAMBXc1P5Jye9FaWV0uT1GopsAUKy+1cnv7csv2sHQ GX0uG4vJO2ki1tFQFu8D1kfmHXslgZjZqUwsUOYz9T7TrOXOPn2LIaiw1V1CVC0IdoO3 81n1OXO51FlKT0hxSGSCnlmXsiwcAqDz1vVAqF521APybS4rAG1WWrIVnyOPXHtj5Lok G/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695271277; x=1695876077; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YfcUvSTLjAeluMlyug41ie2E6IIvnxGKxfLMCD7tBf4=; b=jCu1uyBQBOZmeSgX7Y9bLlK/DeguzBGDEGzmCIBCZwT2Ay2o0hvYWdSlQVD2vBfQ2/ D3iE/TD4ZQu2/QN5zgpNPFCbyfbd/nsrkmKlnlgDd2usV4PhHftWCyxxmGTMWqXDxJs3 oqmKvKFCQV276qr6eAgRfB4slxDSQZhog6Mzx/Bk/p3MIN/ZEqq6ocd6lickeEA9fcpD 0VYCs6BNlg+btmSUB2DnMdLd9xf0rrCKxZeFy1Ugt1PtrlaoS7e1A/YvZutrZCICZN3S W6nlONybVUW9YAq2fnV9bOX0cjVfaxv0jEf0zSOpHT1g8J487nabOuRWpCCfuCcsZZjQ 79nQ== X-Gm-Message-State: AOJu0Yz7MO1qBBxy43kLlsnbiQ7PXS9TE6dxEqEVYa65hA55LmK5h+Iz H8a/pcRi8r4EaT4dKku9ZO0= X-Google-Smtp-Source: AGHT+IE39PwXEz1xsMsuAwnL76x/EeahbPHAIKQAUBal8L8c4fWUOsNKPz9FJvwJN24tPuSxYW2LLg== X-Received: by 2002:aa7:db52:0:b0:523:3e27:caa7 with SMTP id n18-20020aa7db52000000b005233e27caa7mr6432742edt.20.1695271277353; Wed, 20 Sep 2023 21:41:17 -0700 (PDT) Received: from [10.31.0.70] ([89.207.171.102]) by smtp.gmail.com with ESMTPSA id r22-20020aa7da16000000b00532c84e6997sm282675eds.23.2023.09.20.21.41.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 21:41:16 -0700 (PDT) Message-ID: Date: Thu, 21 Sep 2023 06:41:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= To: Jonathan Wakely Cc: libstdc++ , gcc-patches References: <55f0212a-f8d3-aa9e-8788-f5165484ac6c@gmail.com> <520bd324-39e8-45e0-a367-3d1195c1807f@gmail.com> Content-Language: en-US In-Reply-To: <520bd324-39e8-45e0-a367-3d1195c1807f@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tests were successful, ok to commit ? On 20/09/2023 19:51, François Dumont wrote: > libstdc++: [_GLIBCXX_INLINE_VERSION] Add handle_contract_violation > symbol alias > > libstdc++-v3/ChangeLog: > >     * src/experimental/contract.cc >     [_GLIBCXX_INLINE_VERSION](handle_contract_violation): Provide > symbol alias >     without version namespace decoration for gcc. > > Here is what I'm testing eventually, ok to commit if successful ? > > François > > On 20/09/2023 11:32, Jonathan Wakely wrote: >> On Wed, 20 Sept 2023 at 05:51, François Dumont via Libstdc++ >> wrote: >>> libstdc++: Remove std::constract_violation from versioned namespace >> Spelling mistake in contract_violation, and it's not >> std::contract_violation, it's std::experimental::contract_violation >> >>> GCC expects this type to be in std namespace directly. >> Again, it's in std::experimental not in std directly. >> >> Will this change cause problems when including another experimental >> header, which does put experimental below std::__8? >> >> I think std::__8::experimental and std::experimental will become >> ambiguous. >> >> Maybe we do want to remove the inline __8 namespace from all >> experimental headers. That needs a bit more thought though. >> >>> libstdc++-v3/ChangeLog: >>> >>>       * include/experimental/contract: >>>       Remove >>> _GLIBCXX_BEGIN_NAMESPACE_VERSION/_GLIBCXX_END_NAMESPACE_VERSION. >> This line is too long for the changelog. >> >>> It does fix 29 g++.dg/contracts in gcc testsuite. >>> >>> Ok to commit ? >>> >>> François