Re: Re: [PATCH v2 2/2] libstdc++: Use using instead of typedef in opts-common.h

[Ken Matsui <kmatsui@cs.washington.edu>]

On Thu, 11 Jan 2024 at 09:55, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>    On Thu, 11 Jan 2024, 09:43 Ken Matsui, <[1]kmatsui@gcc.gnu.org> wrote:       
>                                                                                 
>    > libstdc++-v3/ChangeLog:                                                    
>                                                                                 
>    >         * src/filesystem/ops-common.h (stat_type): Use using.              
>                                                                                 
>    > Signed-off-by: Ken Matsui <[2]kmatsui@gcc.gnu.org>                         
>    > ---                                                                        
>    >  libstdc++-v3/src/filesystem/ops-common.h | 4 ++--                         
>    >  1 file changed, 2 insertions(+), 2 deletions(-)                           
>                                                                                 
>    > diff --git a/libstdc++-v3/src/filesystem/ops-common.h                      
>    > b/libstdc++-v3/src/filesystem/ops-common.h                                 
>    > index d78a54754c2..e302d8caae6 100644                                      
>    > --- a/libstdc++-v3/src/filesystem/ops-common.h                             
>    > +++ b/libstdc++-v3/src/filesystem/ops-common.h                             
>    > @@ -118,7 +118,7 @@ namespace __gnu_posix                                  
>    >    inline int close(int fd)                                                
>    >    { return ::_close(fd); }                                                
>                                                                                 
>    > -  typedef struct ::__stat64 stat_type;                                    
>    > +  using stat_type = struct ::_stat64;                                     
>                                                                                 
>    You've removed an underscore, is that intentional? Has this been compiled    
>    + tested with mingw?                                                         
This is totally unintentional.  I'll fix it.  I've tested it with Linux
and do not have a mingw environment to test it with.  Would you have any
suggestions on how to test it?

>                                                                                 
>    >    inline int stat(const wchar_t* path, stat_type* buffer)                 
>    >    { return ::_wstat64(path, buffer); }                                    
>    > @@ -184,7 +184,7 @@ namespace __gnu_posix                                  
>    >    using ::open;                                                           
>    >    using ::close;                                                          
>    >  # ifdef _GLIBCXX_HAVE_SYS_STAT_H                                          
>    > -  typedef struct ::stat stat_type;                                        
>    > +  using stat_type = struct ::stat;                                        
>    >    using ::stat;                                                           
>    >  #  ifdef _GLIBCXX_USE_LSTAT                                               
>    >    using ::lstat;                                                          
>    > --                                                                         
>    > 2.43.0                                                                     
> 
> References
> 
>    Visible links
>    1. mailto:kmatsui@gcc.gnu.org
>    2. mailto:kmatsui@gcc.gnu.org

-- 
Ken Matsui