From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00641c01.pphosted.com (mx0a-00641c01.pphosted.com [205.220.165.146]) by sourceware.org (Postfix) with ESMTPS id 806913857731; Thu, 11 Jan 2024 10:10:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 806913857731 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 806913857731 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.165.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704967817; cv=none; b=xpDPQy4OW/SYChN3CgFlKhKTB4W4hgJ5Ic5mQ362PfE7U2WYuJV+5p+285aV6vZQ54V0iwzvYlj/BgTtZVfnFqvMcJUhztr8BfU1PAa9Ezg7MfdQ2qfadEdD4VwMvnwXOkCKia80TIBuTUAjkFdJH1c0nL+bFE1zCvk9XadgIhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704967817; c=relaxed/simple; bh=AO5T1P4h0YTLrCmE7+o75J/OaRbCoDy3GAgtqzMOxH0=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=SCgpyRyzKGOkRb36HFLKsCqNBMUrwnCps1e3YYTlCUYi0fNLlR99EjpQ9ZQucS/4q6cRcYejTDZ7wWyOpFOiqt0eR6u97JkomrB6HYK7eaAkKxbvLlLVqZj65LIrhYvGfxfmk6rbGV6n6+5pJJ9M+UWC/tHOnLXpF+bMemgnY78= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247470.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40BA7xZ2028702; Thu, 11 Jan 2024 10:10:13 GMT Received: from mxout26.s.uw.edu (mxout26.s.uw.edu [140.142.234.176]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3vjc0agdh2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jan 2024 10:10:13 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout26.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 40BAA2WC030500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jan 2024 02:10:02 -0800 X-Auth-Received: from Kens-MacBook-Pro-4.local ([10.154.75.53]) (authenticated authid=kmatsui@cs.washington.edu) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 40BAA2qt014048 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jan 2024 02:10:02 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu Date: Thu, 11 Jan 2024 02:10:02 -0800 From: Ken Matsui To: Jonathan Wakely Cc: Ken Matsui , gcc-patches , libstdc++ Subject: Re: Re: [PATCH v2 2/2] libstdc++: Use using instead of typedef in opts-common.h Message-ID: References: <20240111062222.525186-1-kmatsui@gcc.gnu.org> <20240111094038.876653-1-kmatsui@gcc.gnu.org> <20240111094038.876653-2-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Proofpoint-ORIG-GUID: lU1t_8earARyTmVn0M9KNSQW9YtS0wTX X-Proofpoint-GUID: lU1t_8earARyTmVn0M9KNSQW9YtS0wTX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-11_05,2024-01-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 impostorscore=0 mlxlogscore=999 spamscore=0 phishscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401110081 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 11 Jan 2024 at 09:55, Jonathan Wakely wrote: > On Thu, 11 Jan 2024, 09:43 Ken Matsui, <[1]kmatsui@gcc.gnu.org> wrote: > > > libstdc++-v3/ChangeLog: > > >         * src/filesystem/ops-common.h (stat_type): Use using. > > > Signed-off-by: Ken Matsui <[2]kmatsui@gcc.gnu.org> > > --- > >  libstdc++-v3/src/filesystem/ops-common.h | 4 ++-- > >  1 file changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/libstdc++-v3/src/filesystem/ops-common.h > > b/libstdc++-v3/src/filesystem/ops-common.h > > index d78a54754c2..e302d8caae6 100644 > > --- a/libstdc++-v3/src/filesystem/ops-common.h > > +++ b/libstdc++-v3/src/filesystem/ops-common.h > > @@ -118,7 +118,7 @@ namespace __gnu_posix > >    inline int close(int fd) > >    { return ::_close(fd); } > > > -  typedef struct ::__stat64 stat_type; > > +  using stat_type = struct ::_stat64; > > You've removed an underscore, is that intentional? Has this been compiled > + tested with mingw? This is totally unintentional. I'll fix it. I've tested it with Linux and do not have a mingw environment to test it with. Would you have any suggestions on how to test it? > > >    inline int stat(const wchar_t* path, stat_type* buffer) > >    { return ::_wstat64(path, buffer); } > > @@ -184,7 +184,7 @@ namespace __gnu_posix > >    using ::open; > >    using ::close; > >  # ifdef _GLIBCXX_HAVE_SYS_STAT_H > > -  typedef struct ::stat stat_type; > > +  using stat_type = struct ::stat; > >    using ::stat; > >  #  ifdef _GLIBCXX_USE_LSTAT > >    using ::lstat; > > -- > > 2.43.0 > > References > > Visible links > 1. mailto:kmatsui@gcc.gnu.org > 2. mailto:kmatsui@gcc.gnu.org -- Ken Matsui