From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id 905943850206; Fri, 24 Jun 2022 12:37:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 905943850206 Received: from [IPv6:2408:8471:1105:d98f:ee19:e7c3:baa3:409c] (unknown [IPv6:2408:8471:1105:d98f:ee19:e7c3:baa3:409c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 5F082669EE; Fri, 24 Jun 2022 08:37:25 -0400 (EDT) Message-ID: Subject: Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts From: Xi Ruoyao To: Rainer Orth , Jonathan Wakely Cc: Jonathan Wakely , libstdc++ , gcc-patches Date: Fri, 24 Jun 2022 20:37:20 +0800 In-Reply-To: References: <74ea0c62ebe19db186263053e4051f81d46e9da4.camel@xry111.site> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FROM_SUSPICIOUS_NTLD, LIKELY_SPAM_FROM, PDS_OTHER_BAD_TLD, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 12:37:34 -0000 On Fri, 2022-06-24 at 13:41 +0200, Rainer Orth wrote: > Hi Jonathan, >=20 > > > > I'll need some rework as Rainer told me "grep -E" may not work on s= ome > > > > Solaris systems w/o GNU grep, and the code snippet in extract_symve= rs.in > > > > is exactly for Solaris... > > >=20 > > > I checked that, and it's not :-) > > >=20 > > > The egrep uses in extract_symvers.in are for everything *except* > > > SunOS. For Solaris we use the scripts/extract_symvers.pl script > > > instead. I misread the case statement :(. > > > Your change might break generation of Doxygen API docs on Solaris, bu= t > > > maybe we can live with that. > >=20 > > /usr/xpg4/bin/grep supports the -E flag, so I was going to say that > > it's acceptable to require that version in the PATH when generating > > the API docs with doxygen. But in fact that script already assumes GNU >=20 > indeed: for a niche/developer-only use, the bar of tool requirements can > be higher IMO.=C2=A0 Besides, /usr/gnu/bin/grep is there, too (or could b= e; > both /usr/xpg4/bin/grep and /usr/gnu/bin/grep live in separate packages > that may or may not be installed). >=20 > I just want to make the entry barries for normal builds as low as > possible. Pushed as r13-1242 with ChangeLog fix, as compatibility-related stuff "resolved" and this does not depend on other patches in the series. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University