From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=pT2m=C6=xry111.site=xry111@sourceware.org>
Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1])
	by sourceware.org (Postfix) with ESMTPS id DA76A3858C62;
	Wed, 12 Jul 2023 18:56:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA76A3858C62
Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site;
	s=default; t=1689188188;
	bh=nyMNMM8SGr/XtwzJdgYWcq5LMKhXM1AGjbES/jmftOA=;
	h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
	b=DDp6lxJlWDuX7Nk59/ayAxo5PKI+ouwiIeyuXjUBxC1YdACGOht7ZqwkDOPlHQrAb
	 uZqU1ygrm+v2mVhgl+EcqGMeGwDQcbj7wwBvz4oXKQTidkZGw3T9K7XHeIm9J30+QN
	 +idJIw0PhbeSk+dr4MMkil8YE1CAS1diURoroeVk=
Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384)
	(Client did not present a certificate)
	(Authenticated sender: xry111@xry111.site)
	by xry111.site (Postfix) with ESMTPSA id BDB6565B8A;
	Wed, 12 Jul 2023 14:56:27 -0400 (EDT)
Message-ID: <e53224cec4725d8312e7013db136f53f9294b892.camel@xry111.site>
Subject: Re: [PATCH v2 2/2] libstdc++: use new built-in trait __is_scalar
 for std::is_scalar
From: Xi Ruoyao <xry111@xry111.site>
To: Ken Matsui <kmatsui@cs.washington.edu>, Jonathan Wakely
 <jwakely@redhat.com>
Cc: Ken Matsui <kmatsui@gcc.gnu.org>, gcc-patches@gcc.gnu.org, 
	libstdc++@gcc.gnu.org
Date: Thu, 13 Jul 2023 02:56:26 +0800
In-Reply-To: <CAML+3pV0sCoQCu4MyODZ_rCf2ht6LjzStZkTtn=q=12+SeqY5g@mail.gmail.com>
References: 
	<CAML+3pUCOjsgUSCks_57KUnyKkaSET8M72NqOAJv1iFFUK7WTQ@mail.gmail.com>
	 <20230708044539.61276-1-kmatsui@gcc.gnu.org>
	 <20230708044539.61276-2-kmatsui@gcc.gnu.org>
	 <CACb0b4nEQkxjLDDF9BgTCwuMg7Ew0nSnbPxsrtG7NKMtcT_QSA@mail.gmail.com>
	 <CAML+3pV0sCoQCu4MyODZ_rCf2ht6LjzStZkTtn=q=12+SeqY5g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libstdc++.gcc.gnu.org>

On Wed, 2023-07-12 at 11:32 -0700, Ken Matsui via Gcc-patches wrote:
> > conditional on the front-end change being committed first of course
>=20
> Does this mean we want to commit this [2/2] patch before committing
> the [1/2] patch in this case?

No, this mean you should get 1/2 reviewed and committed first.

> Also, can I tweak the commit message without being approved again,
> such as attaching the benchmark result?

Yes, as long as the ChangeLog is still correct (the Git hook will reject
a push with wrong ChangeLog format anyway).

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University