From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <joseph_myers@mentor.com>
Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98])
	by sourceware.org (Postfix) with ESMTPS id 90AF33858C36;
	Mon,  7 Nov 2022 17:52:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 90AF33858C36
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="5.96,145,1665475200"; 
   d="scan'208";a="86465431"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
  by esa2.mentor.iphmx.com with ESMTP; 07 Nov 2022 09:52:18 -0800
IronPort-SDR: n2UiiAlnocmcieeakCl4BkIbTanzosq9YQ5gk+KkzFeDCb9SK+fjIOQEcQ241dGG69pbc4peUB
 njQk2JK0GYB+Ek4flRI+6+ny2M4x3Fkk2fuarR4a2eJPWP4ztbF/pCGndMHM2tX0pIEPCQLBSv
 eQ9AHYiEX5/7OUFPzOAskSIqt87AWMctpNknysFe/M1TlGft6ecucsanHWAnsSIhw0QRR5Gjim
 i3mHId6XXZrgLOGadLkkb5qzEGK58sgcFQ0w7w7MTxnjSOYVG4R2cC8OHjGT2oUzj61n/TP/kL
 3Ow=
Date: Mon, 7 Nov 2022 17:52:13 +0000
From: Joseph Myers <joseph@codesourcery.com>
To: Jonathan Wakely <jwakely@redhat.com>
CC: Jakub Jelinek <jakub@redhat.com>, Patrick Palka <ppalka@redhat.com>,
	<libstdc++@gcc.gnu.org>, <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Add _Float128 to_chars/from_chars support
 for x86, ia64 and ppc64le with glibc
In-Reply-To: <CACb0b4nU=KV8kn12CGtfumATLfSnpJGg+vhLj4mAcZqw4=o07w@mail.gmail.com>
Message-ID: <ec68e61c-da7e-cabc-ded0-14bc42d485e1@codesourcery.com>
References: <Y2I3pr1Eyn120h1C@tucnak> <6cffcff-f879-c122-2aeb-fa53714511ac@codesourcery.com> <CACb0b4nU=KV8kn12CGtfumATLfSnpJGg+vhLj4mAcZqw4=o07w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To
 svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10)
X-Spam-Status: No, score=-3110.2 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libstdc++.gcc.gnu.org>

On Mon, 7 Nov 2022, Jonathan Wakely wrote:

> This seems to "fix" it (not sure if it's right though):
> 
> #ifndef _GLIBCXX_HAVE_FLOAT128_MATH
> extern "C" _Float128 __strtof128(const char*, char**)
>  __attribute__((__weak__));
> #endif
> extern "C" _Float128 __strtof128(const char*, char**)
>  __asm ("strtof128");

Probably putting the __asm before the __attribute__ would also work 
without needing a separate declaration (but might be less convenient for 
the #if conditionals).

-- 
Joseph S. Myers
joseph@codesourcery.com