From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id A530F3856961 for ; Thu, 7 Sep 2023 17:29:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A530F3856961 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2bceca8a41aso20489871fa.0 for ; Thu, 07 Sep 2023 10:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694107786; x=1694712586; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RFSGFUBGW5uWrzB54eexldF0ypl5dqy+PxwUiu4RJoM=; b=m2R+osvNSF0oZRPGNpuEf0JIgiZPwtkEfAgNve/ds2vRLbKTwcivDT8L2XflIWOTiw PzPSMY1zQyShl+C0sctvOWI3kZ0KwR9BYNcdwy1Nnym7QUCT4j4Q3pNk/lCZyiLmyRjw xomS/ZRikKxhRtOjT8QHPJUKVHAz8tjjMtPunm8Ws3nOpE4Eq4Abd/tpPEnnyxbYpsuJ eIEhyhyKbSrK9WMdKFREPiBe4wPfjLoPseDRnC5337lqQm50AC9ka1tZWIRanOUEqtVU 3bF1X6RS4lBkaRIJRQA2gU28bKjKF8fy/kxye5glMLXrDYaUxYXhYKxzUFhl7MPfcxIW 7eiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694107786; x=1694712586; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RFSGFUBGW5uWrzB54eexldF0ypl5dqy+PxwUiu4RJoM=; b=VZwIbCSvv9a2M4ZUuyW7/uRlPqNerhwXmyY0Ldo9rqbhhNihGqfvlf4RXCvFVpHb5Q SFtqebbe1cyInPnlxFfGjYbWvSq6BjRpRccJB210nF17fRlk3Q18WFW8rrxbprM8SS/l Eqg9ZJl+RerwvNgP3NiAj/f03Rg7r5nL5CbDWg5fjX0+bBR2cC39sknHQLsKYLF9spGk PhKGtiGu1mqfui7kjBLljc+zWaB1yMc6wZ/wORHQmtZz7lYqmAphbtfPEKrag1DYsqgQ BSMoi6VP4vIub+Fyi/QikbpkY4OilBE4UpFUz2E8Dz02xaqi6evUwV/6Rl6ojZ239RuZ EU4Q== X-Gm-Message-State: AOJu0YzBor83J6qV433u3mOw2xbDPoyr6tFEYG4vGUICEhM52TlusMgl kb7R2L5aeBfCQTo3RDvfuqk= X-Google-Smtp-Source: AGHT+IGBxTTCWACoVYQKOlCBWg7EJAQ8V6ubkz2EPZxdwfzn4nBV6HafSv7lWfyoD6LlMGMjmlgF+Q== X-Received: by 2002:a2e:9b04:0:b0:2bc:d43c:8607 with SMTP id u4-20020a2e9b04000000b002bcd43c8607mr4990582lji.14.1694107786212; Thu, 07 Sep 2023 10:29:46 -0700 (PDT) Received: from [10.25.1.214] ([89.207.171.100]) by smtp.gmail.com with ESMTPSA id h21-20020a1709060f5500b009a1be9c29d7sm10767784ejj.179.2023.09.07.10.29.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Sep 2023 10:29:45 -0700 (PDT) Message-ID: Date: Thu, 7 Sep 2023 19:29:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] libstdc++: Reduce output of 'make check' Content-Language: en-US To: Jonathan Wakely , libstdc++@gcc.gnu.org References: <20230907133202.1013843-1-jwakely@redhat.com> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: <20230907133202.1013843-1-jwakely@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: +1 for this cleanup, thanks. Sorry to troll but I noticed another annoying recent behavior. Maybe the one who did it will recognize himself and will be willing to find a solution :-) When I create a testsuite_files file with 1 test case I have the following output: Running /home/fdumont/dev/gcc/git/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp ...         === libstdc++ Summary === # of expected passes        6 It should be 2. There are 4 additional tests coming from experimental/simd folder. I guess they are automatically added for good reasons. But it would be great to add those only if there is no testsuite_files. On 07/09/2023 15:31, Jonathan Wakely via Libstdc++ wrote: > Any objections to this change? > > -- >8 -- > > This removes the 39 lines of shell commands that get echoed when > starting the testsuite. The fact that near the end of that output it > prints `echo "WARNING: could not find \`runtest'" 1>&2; :;` makes it > look like that warning is actually being shown the the user. > > Suppress echoing the recipe, so that users only see the actual output > from the testsuite, not the makefile recipe as well. > > libstdc++-v3/ChangeLog: > > * testsuite/Makefile.am (check-DEJAGNU): Use @ in recipe. > * testsuite/Makefile.in: Regenerate. > --- > libstdc++-v3/testsuite/Makefile.am | 2 +- > libstdc++-v3/testsuite/Makefile.in | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/testsuite/Makefile.am b/libstdc++-v3/testsuite/Makefile.am > index 7adc5318192..4cee585fd8e 100644 > --- a/libstdc++-v3/testsuite/Makefile.am > +++ b/libstdc++-v3/testsuite/Makefile.am > @@ -117,7 +117,7 @@ $(check_DEJAGNU_normal_targets): check-DEJAGNUnormal%: normal%/site.exp > > # Run the testsuite in normal mode. > check-DEJAGNU $(check_DEJAGNU_normal_targets): check-DEJAGNU%: site.exp > - $(if $*,@)AR="$(AR)"; export AR; \ > + @$(if $*,@)AR="$(AR)"; export AR; \ > RANLIB="$(RANLIB)"; export RANLIB; \ > if [ -z "$*" ] && [ -n "$(filter -j%, $(MFLAGS))" ]; then \ > rm -rf normal-parallel || true; \ >