From: "François Dumont" <frs.dumont@gmail.com>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH][_GLIBCXX_DEBUG] Add basic_string::starts_with/ends_with checks
Date: Sun, 14 Aug 2022 17:32:50 +0200 [thread overview]
Message-ID: <f41daeb7-45dc-4e5c-ce18-17306171a837@gmail.com> (raw)
I think we can add those checks.
Note that I wonder if it was needed as in basic_string_view I see usages
of __attribute__((__nonnull__)). But running the test I saw no impact
even after I try to apply this attribute to the starts_with/ends_with
methods themselves.
Also note that several checks like the ones I am adding here are XFAILS
when using 'make check' because of the segfault rather than on a proper
debug checks. Would you prefer to add dg-require-debug-mode to those ?
libstdc++: [_GLIBCXX_DEBUG] Add basic_string::starts_with/ends_with
checks
Add simple checks on C string parameters which should not be null.
Review null string checks to show:
_String != nullptr
rather than:
_String != 0
libstdc++-v3/ChangeLog:
* include/bits/basic_string.h (starts_with, ends_with): Add
__glibcxx_check_string.
* include/bits/cow_string.h (starts_with, ends_with): Likewise.
* include/debug/debug.h: Use nullptr rather than '0' in
checks in C++11.
* include/debug/string: Likewise.
*
testsuite/21_strings/basic_string/operations/ends_with/char.cc: Use
__gnu_test::string.
*
testsuite/21_strings/basic_string/operations/ends_with/wchar_t.cc: Use
__gnu_test::wstring.
*
testsuite/21_strings/basic_string/operations/starts_with/wchar_t.cc: Use
__gnu_test::wstring.
*
testsuite/21_strings/basic_string/operations/starts_with/char.cc: Use
__gnu_test::string.
*
testsuite/21_strings/basic_string/operations/ends_with/char_neg.cc: New
test.
*
testsuite/21_strings/basic_string/operations/ends_with/wchar_t_neg.cc:
New test.
*
testsuite/21_strings/basic_string/operations/starts_with/char_neg.cc:
New test.
*
testsuite/21_strings/basic_string/operations/starts_with/wchar_t_neg.cc:
New test.
Tested under linux normal and debug modes.
François
next reply other threads:[~2022-08-14 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 15:32 François Dumont [this message]
2022-08-15 20:26 ` François Dumont
2022-08-25 16:11 ` François Dumont
2022-08-26 9:33 ` Jonathan Wakely
2022-08-26 9:31 ` Jonathan Wakely
2022-08-31 4:38 ` [PATCH][_GLIBCXX_DEBUG] Review null string assertions (was: Add basic_string::starts_with/ends_with checks) François Dumont
2022-08-31 9:25 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f41daeb7-45dc-4e5c-ce18-17306171a837@gmail.com \
--to=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).