From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id ABE6D3858D28; Wed, 20 Mar 2024 18:11:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ABE6D3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ABE6D3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::330 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710958264; cv=none; b=Wq3LQ3gPJzgeqqdtK+Gj1FC4fJ88eFf5Pn2QSCek8ktvoQmWYdy/ByQHpff7BAS9iZIDH6YalUjlhleZ/xpj+8BIh2MwYcqR+yQnpIrm1fuxm7AeSdUEgQIOhW1R70FNJAMpeuinyO5OrRvkOQS8dukquXY1SFy7I1zrPUIZyvA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710958264; c=relaxed/simple; bh=mzhwJcKcc1Um+96X7hgIuW3AS/4RSadg1OyhF8u+wpk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kzBKnC/lHddI2sriU/1YSoDFTYkHt3mIfgkxZbIWwMABHVKmlJBQNDJ8TjEWAt61vh7tJsO/qoKIfN4k/9EuvgTmAKvUiBgjY2mOnVuoIpfE1hVG6bg84u+WjrS4DJfxgTVSDI5kKijn943FG0fZBxZd4uKVTFd+aBFBhH2XNyo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4146e5c719bso879315e9.2; Wed, 20 Mar 2024 11:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710958261; x=1711563061; darn=gcc.gnu.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=q2Wrh7DZs1YOlRxsqM5exhM0hUIrGqAyqfpGL/EjtFk=; b=f9K2vHiE1b0xaHnp2Y51122GwYc1xUUe4vvehCXn1Gq+g4bMFjLn8FPivTXwvlZT9i pl0xb019a7bVbZXwMWOYik22VNNIcjeKXd3CaZCEMP3Z7Hh49tJedE4Asw71cYh6hIJW DYB+7Dn+6UAHuNN4tfcgTUFkp3UP425lov3WsCbRxk+piuj14N10XXiZjSWxzn85y7Yr YZxgJ5Q8aHqcbeU41yL40dWHFHv4NI4jUOkV8FfGUXztVSg8Axb7I8kFUxboEQKxqAu8 /kymYkaSsk+cfJQcSkqeqEGAVe6nsOQe7AQdcA+6giWFQrbzZMKKEGcWK2PfC+3rAOLh EUqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710958261; x=1711563061; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=q2Wrh7DZs1YOlRxsqM5exhM0hUIrGqAyqfpGL/EjtFk=; b=dp0gVF/hhdc1m5I10BBv7qucalYh3sUKh697nNkmi0RPdm+I1UiacHzPTeyY0rIIwX 6C2Thb6tWpNd28y6ebNS0kx8ueAR79843QnaHHctZH5vHJ3MRjadP0OCoYcCbR/xsbkX v3afAQgd47YLbTlKC3ZCVf3Ih5+BIqzpZZWSRetYmee9lPIrkQUnREEBpkYalJWwjxpG 1vEByjJZcu68K1WJoFCG7tZhWdqEIKw115zn6d32FxEDbpO4Mp0QA1BSisIX+ME5DUv6 SDYcUdGdTmEi6tSNYblaKEUprgD1ygaYacfJ+islxJ3fIVsjV5Yvgvtkg0xZMecWufu5 4UGQ== X-Forwarded-Encrypted: i=1; AJvYcCWor8j1dfv1nBNsQrhKw2tJ43HJATsHnWeImddcPeryzsnnGRdQ9QWIT/q/vnpnKBazNHX64APAogFiSgiud7dZntmfkVhjEj/f0Hx+2VQ0ty6ccqju8DSI7HKZirLF X-Gm-Message-State: AOJu0YxNto9XvZbzyxpqbcLZw8PEv4TybuCT92BQm0H1DD+YC2UtRzAi kc/TfZhF2Wv+AIB6FAetw1GdMOOXomwGh/zTSSVo8s6JvHykjBtg X-Google-Smtp-Source: AGHT+IGXzi0VLtBCMz7yqQHu/EgVkssd+OboeXATqygieaSWvU3mxTCTMOwwiVzlQNf/sedkpZXafg== X-Received: by 2002:adf:ef04:0:b0:33d:c33e:fbd2 with SMTP id e4-20020adfef04000000b0033dc33efbd2mr2110577wro.31.1710958261087; Wed, 20 Mar 2024 11:11:01 -0700 (PDT) Received: from [10.62.0.228] ([89.207.171.133]) by smtp.gmail.com with ESMTPSA id f5-20020adffcc5000000b0033e7b05edf3sm15227902wrs.44.2024.03.20.11.10.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 11:11:00 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------pX1sC0F9wd0fxSEfkt8tPHsa" Message-ID: Date: Wed, 20 Mar 2024 19:10:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: _LIBCXX_DEBUG value initialized singular iterators assert failures in std algorithms [PR104316] To: Jonathan Wakely Cc: Jonathan Wakely , libstdc++ , gcc-patches References: <73AC0523-2237-46FD-9885-7AE3F8663DF2@gmail.com> <28CE4FD1-FFB0-4300-81CA-C3CB07E436A6@gmail.com> <19f5939a-9341-4237-90d9-4f1279f03a88@gmail.com> <2f29d2f2-a21b-42bb-997f-3918935d0dba@gmail.com> <4374668e-f7e9-4912-a8e6-a50710999d4b@gmail.com> <114c9cc7-6990-48be-87b9-b8ac02015531@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= In-Reply-To: X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------pX1sC0F9wd0fxSEfkt8tPHsa Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit As proposed below I also updated gcc-13 branch.     libstdc++: [_GLIBCXX_DEBUG] Define __cpp_lib_null_iterators     _GLIBCXX_DEBUG has now fully N3344 compliant iterator checks, we can define     __cpp_lib_null_iterators macros like the normal mode.     libstdc++-v3/ChangeLog:             * include/std/iterator (__cpp_lib_null_iterators): Define regardless of             _GLIBCXX_DEBUG.             * include/std/version (__cpp_lib_null_iterators): Likewise. François On 20/03/2024 10:02, Jonathan Wakely wrote: > On Wed, 20 Mar 2024 at 05:59, François Dumont wrote: >> Thanks to you doc: >> >> libstdc++: [_GLIBCXX_DEBUG] Define __[glibcxx,cpp_lib]_null_iterators >> >> _GLIBCXX_DEBUG has now fully N3344 compliant iterator checks, we >> can define >> __glibcxx_null_iterators and __cpp_lib_null_iterators macros like >> the normal >> mode. >> >> libstdc++-v3/ChangeLog: >> >> * version.def (null_iterators): Remove extra_cond. >> * version.h: Regenerate. >> >> Ok to commit ? > Please don't bother talking about __glibcxx_null_iterators in the > commit message, that's an implementation detail that always mirrors > the standard-defined __cpp_lib_null_iterators one. The first line of > the commit will be much easier to read without that. > > OK with that change, thanks. > >> I already noticed that GCC 13 has no version.h file so no backport question. > It has no version.h but it still has the macros: > > include/std/iterator:# define __cpp_lib_null_iterators 201304L > include/std/version:# define __cpp_lib_null_iterators 201304L > > Those definitions can be made to not depend on _GLIBCXX_DEBUG. > --------------pX1sC0F9wd0fxSEfkt8tPHsa Content-Type: text/plain; charset=UTF-8; name="version_patch.txt" Content-Disposition: attachment; filename="version_patch.txt" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC9pdGVyYXRvciBiL2xpYnN0 ZGMrKy12My9pbmNsdWRlL3N0ZC9pdGVyYXRvcgppbmRleCA2OTVlMThlMmM0Ny4uYTBhOGVh YzU3MGIgMTAwNjQ0Ci0tLSBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC9pdGVyYXRvcgor KysgYi9saWJzdGRjKystdjMvaW5jbHVkZS9zdGQvaXRlcmF0b3IKQEAgLTY3LDcgKzY3LDcg QEAKICNlbmRpZgogI2luY2x1ZGUgPGJpdHMvcmFuZ2VfYWNjZXNzLmg+CiAKLSNpZiBfX2Nw bHVzcGx1cyA+PSAyMDE0MDJMICYmICEgZGVmaW5lZCBfR0xJQkNYWF9ERUJVRyAvLyBQUiBs aWJzdGRjKysvNzAzMDMKKyNpZiBfX2NwbHVzcGx1cyA+PSAyMDE0MDJMCiAjIGRlZmluZSBf X2NwcF9saWJfbnVsbF9pdGVyYXRvcnMgMjAxMzA0TAogI2VuZGlmCiAKZGlmZiAtLWdpdCBh L2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC92ZXJzaW9uIGIvbGlic3RkYysrLXYzL2luY2x1 ZGUvc3RkL3ZlcnNpb24KaW5kZXggYmQxYmVlMDE5MGQuLmVlNTE1YzRlNjZjIDEwMDY0NAot LS0gYS9saWJzdGRjKystdjMvaW5jbHVkZS9zdGQvdmVyc2lvbgorKysgYi9saWJzdGRjKyst djMvaW5jbHVkZS9zdGQvdmVyc2lvbgpAQCAtODEsOSArODEsNyBAQAogI2RlZmluZSBfX2Nw cF9saWJfaW50ZWdyYWxfY29uc3RhbnRfY2FsbGFibGUgMjAxMzA0TAogI2RlZmluZSBfX2Nw cF9saWJfaXNfZmluYWwgMjAxNDAyTAogI2RlZmluZSBfX2NwcF9saWJfbWFrZV9yZXZlcnNl X2l0ZXJhdG9yIDIwMTQwMkwKLSNpZm5kZWYgX0dMSUJDWFhfREVCVUcgLy8gUFIgbGlic3Rk YysrLzcwMzAzCi0jIGRlZmluZSBfX2NwcF9saWJfbnVsbF9pdGVyYXRvcnMgMjAxMzA0TAot I2VuZGlmCisjZGVmaW5lIF9fY3BwX2xpYl9udWxsX2l0ZXJhdG9ycyAyMDEzMDRMCiAjZGVm aW5lIF9fY3BwX2xpYl9yb2J1c3Rfbm9ubW9kaWZ5aW5nX3NlcV9vcHMgMjAxMzA0TAogI2Rl ZmluZSBfX2NwcF9saWJfdHJhbnNmb3JtYXRpb25fdHJhaXRfYWxpYXNlcyAyMDEzMDRMCiAj ZGVmaW5lIF9fY3BwX2xpYl90cmFuc3BhcmVudF9vcGVyYXRvcnMgMjAxNTEwTAo= --------------pX1sC0F9wd0fxSEfkt8tPHsa--