From: Jason Merrill <jason@redhat.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: gcc-patches@gcc.gnu.org, jwakely@redhat.com, libstdc++@gcc.gnu.org
Subject: Re: [PATCH 1/3] libstdc++: Improve output of default contract violation handler [PR107792]
Date: Tue, 20 Dec 2022 12:23:44 -0500 [thread overview]
Message-ID: <fb8a7186-55a0-0f2a-1cc6-3e34932c23f2@redhat.com> (raw)
In-Reply-To: <20221220104916.3000540-1-arsen@aarsen.me>
On 12/20/22 05:49, Arsen Arsenović wrote:
> From: Jonathan Wakely <jwakely@redhat.com>
>
> Make the output more readable. Don't output anything unless verbose
> termination is enabled at configure-time.
>
> libstdc++-v3/ChangeLog:
>
> PR libstdc++/107792
> PR libstdc++/107778
> * src/experimental/contract.cc (handle_contract_violation): Make
> output more readable.
> ---
> Alright, updated to omit information that's defaulted.
>
> Turns out your suggestion for dg-output was quite clever - because {} is
> special in ARE, it's always prefixed by \ when escaping with curlies,
> and so it never counds towards the "paired curly braces" rules, and
> requires no extra escaping code at all! That's quite a bit neater.
>
> libstdc++-v3/src/experimental/contract.cc | 50 ++++++++++++++++++-----
> 1 file changed, 39 insertions(+), 11 deletions(-)
>
> diff --git a/libstdc++-v3/src/experimental/contract.cc b/libstdc++-v3/src/experimental/contract.cc
> index c8d2697eddc..fbe8815a5c2 100644
> --- a/libstdc++-v3/src/experimental/contract.cc
> +++ b/libstdc++-v3/src/experimental/contract.cc
> @@ -1,4 +1,5 @@
> // -*- C++ -*- std::experimental::contract_violation and friends
> +
> // Copyright (C) 2019-2022 Free Software Foundation, Inc.
> //
> // This file is part of GCC.
> @@ -23,19 +24,46 @@
> // <http://www.gnu.org/licenses/>.
>
> #include <experimental/contract>
> -#include <iostream>
> +#if _GLIBCXX_HOSTED && _GLIBCXX_VERBOSE
> +# include <iostream>
> +#endif
>
> __attribute__ ((weak)) void
> handle_contract_violation (const std::experimental::contract_violation &violation)
> {
> - std::cerr << "default std::handle_contract_violation called: \n"
> - << " " << violation.file_name()
> - << " " << violation.line_number()
> - << " " << violation.function_name()
> - << " " << violation.comment()
> - << " " << violation.assertion_level()
> - << " " << violation.assertion_role()
> - << " " << (int)violation.continuation_mode()
> - << std::endl;
> +#if _GLIBCXX_HOSTED && _GLIBCXX_VERBOSE
> + bool level_default_p = violation.assertion_level() == "default";
> + bool role_default_p = violation.assertion_role() == "default";
> + bool cont_mode_default_p = violation.continuation_mode()
> + == std::experimental::contract_violation_continuation_mode::never_continue;
> +
> + const char* modes[]{ "never", "maybe" }; // Must match enumerators in header.
> + std::cerr << "contract violation in function " << violation.function_name()
> + << " at " << violation.file_name() << ':' << violation.line_number()
> + << ": " << violation.comment();
> +
> + const char* delimiter = "\n[";
> +
> + if (!level_default_p)
> + {
> + std::cerr << delimiter << "level:" << violation.assertion_level();
> + delimiter = ", ";
> + }
> + if (!role_default_p)
> + {
> + std::cerr << delimiter << "role:" << violation.assertion_role();
> + delimiter = ", ";
> + }
> + if (!cont_mode_default_p)
> + {
> + std::cerr << delimiter << "mode:"
> + << modes[(int)violation.continuation_mode() & 1];
I still think this should be "continuation: on/off".
Jason
next prev parent reply other threads:[~2022-12-20 17:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 9:42 [PATCH 0/4] c++: Small tweaks to contracts Arsen Arsenović
2022-12-10 9:43 ` [PATCH 1/4] contracts: Lowercase {MAYBE,NEVER}_CONTINUE Arsen Arsenović
2022-12-10 11:15 ` Jonathan Wakely
2022-12-15 16:25 ` Jason Merrill
2022-12-15 17:39 ` Arsen Arsenović
2022-12-20 17:16 ` Jason Merrill
2022-12-10 9:43 ` [PATCH 2/4] libstdc++: Improve output of default contract violation handler [PR107792] Arsen Arsenović
2022-12-15 16:28 ` Jason Merrill
2022-12-15 17:43 ` Arsen Arsenović
2022-12-20 10:49 ` [PATCH 1/3] " Arsen Arsenović
2022-12-20 10:49 ` [PATCH 2/3] contracts: Update testsuite against new default viol. handler format Arsen Arsenović
2022-12-20 10:49 ` [PATCH 3/3] contrib: Add dg-out-generator.pl Arsen Arsenović
2022-12-20 15:57 ` Jonathan Wakely
2022-12-20 17:23 ` Jason Merrill [this message]
2022-12-22 11:03 ` [PATCH 1/3] libstdc++: Improve output of default contract violation handler [PR107792] Arsen Arsenović
2022-12-22 21:40 ` Jason Merrill
2022-12-22 22:02 ` Jonathan Wakely
2022-12-22 11:03 ` [PATCH 2/3] contracts: Update testsuite against new default viol. handler format Arsen Arsenović
2022-12-22 11:03 ` [PATCH 3/3] contrib: Add dg-out-generator.pl Arsen Arsenović
2022-12-22 21:43 ` Jason Merrill
2022-12-22 21:56 ` Arsen Arsenović
2022-12-22 22:21 ` Jason Merrill
2022-12-22 22:56 ` Arsen Arsenović
2022-12-10 9:43 ` [PATCH 3/4] contracts: Update testsuite against new default viol. handler format Arsen Arsenović
2022-12-10 9:43 ` [PATCH 4/4] contrib: Add dg-out-generator.pl Arsen Arsenović
2022-12-15 16:30 ` Jason Merrill
2022-12-15 17:30 ` Arsen Arsenović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb8a7186-55a0-0f2a-1cc6-3e34932c23f2@redhat.com \
--to=jason@redhat.com \
--cc=arsen@aarsen.me \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).