From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 046DE3858D39; Tue, 3 Oct 2023 20:15:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 046DE3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4060b623e64so1198495e9.0; Tue, 03 Oct 2023 13:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696364098; x=1696968898; darn=gcc.gnu.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=NU2XV0qArsXGFMkTjWWu0dSVQtBS+6EeQ+tJscz8d+U=; b=PhjakOhnn1vlmKDhtIkldg24UPGvq489ofneF1f/K+1GFQemzVS7f7GLHSnb7rBgAk tjeO8rhgga95lmI8BF+ca4KlnIiDMX/UctKMKsM0hS5aVs118csLnlUB/zH+qWeMGlGy CAOLR2pAlJahVDUUZqq56W8zGjmrRO27FcsOqJ57s/heQSaWkfKGUYmI23fCRLkZPqKo phSWXhD/+MFW2ddYB7ViIcPhOYuiT76lI5/uX+Z9h1oBl+QGiH5E25epW86pk6Gsi+BG lkPwKjfuR/ydvEDax8HzM58H5Yso7arnu+DbJunybCMjOTWlHionl65DkAbrLBOkER0x 0B5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696364098; x=1696968898; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NU2XV0qArsXGFMkTjWWu0dSVQtBS+6EeQ+tJscz8d+U=; b=oVjYamVVC3/Xv5y4DzF1/TP0yYQuE+HoOZToSsNhV2sy2o8osWYFPraviA/7qJ9op8 oGMcC6Vr2f5jEjJtAaNQc9WSvc/p+i/xF/PPBHMd3U50NSMxEXask2gh75r4QQU+jfZ6 xTBo0RP39RJD6EK1GdGRaVZztcIBzzb0/CZ7w+z0UcAJT448BiO073oeRaRAjAdVjkcq RYNblQonh8CLoOzHhU/Nw7j6X8KVi9wiNGa9Nz1l+jIvKMfQT/zeQgWLp0mSlLaW5n6R zL22DQ3E6viDdZs/dt8xen3yMpJda9Gxqa2CoQuT2dbH2hBYNzCosThek/rpTxuNo2k6 22Mg== X-Gm-Message-State: AOJu0YylSQE56u3+Oqr0vS+rfbat9VHhgSCV00kBrbCHzVBA7YNLm95W 6+XPATxY2jqOoSn4I3pnOcs= X-Google-Smtp-Source: AGHT+IHNbtrLQUxJLLqgMqwz84Q6eTb4rurGbgXIycsjTh6jmDgk31dCZN44kf0sMRX0bYUMwJm2Ew== X-Received: by 2002:a05:600c:5101:b0:405:d70d:1790 with SMTP id o1-20020a05600c510100b00405d70d1790mr2800492wms.13.1696364098291; Tue, 03 Oct 2023 13:14:58 -0700 (PDT) Received: from ?IPV6:2a01:e0a:1dc:b1c0:d3a7:edc9:701b:b365? ([2a01:e0a:1dc:b1c0:d3a7:edc9:701b:b365]) by smtp.gmail.com with ESMTPSA id n9-20020a05600c294900b00401c595fcc7sm10152408wmd.11.2023.10.03.13.14.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 13:14:56 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------oy3uM3ZeK0KsH0ns9AFZv2t1" Message-ID: Date: Tue, 3 Oct 2023 22:14:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] Fix coroutine tests for libstdc++ gnu-version-namespace mode To: Jonathan Wakely Cc: gcc@gcc.gnu.org, libstdc++ , gcc-patches References: <4ebb6936-d652-84a5-0028-6ca0a5d2d238@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------oy3uM3ZeK0KsH0ns9AFZv2t1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Indeed ! Here is the right one. On 03/10/2023 11:52, Jonathan Wakely wrote: > On Mon, 2 Oct 2023 at 18:07, François Dumont wrote: >> Hi >> >> Gentle reminder for this minor patch. > It looks like you attached the wrong patch. > > >> Thanks >> >> On 23/09/2023 22:10, François Dumont wrote: >>> I'm eventually fixing those tests the same way we manage this problem >>> in libstdc++ testsuite. >>> >>> testsuite: Add optional libstdc++ version namespace in expected >>> diagnostic >>> >>> When libstdc++ is build with >>> --enable-symvers=gnu-versioned-namespace diagnostics are >>> showing this namespace, currently __8. >>> >>> gcc/testsuite/ChangeLog: >>> >>> * >>> testsuite/g++.dg/coroutines/coro-bad-alloc-00-bad-op-new.C: Add optional >>> '__8' version namespace in expected diagnostic. >>> * >>> testsuite/g++.dg/coroutines/coro-bad-alloc-01-bad-op-del.C: Likewise. >>> * >>> testsuite/g++.dg/coroutines/coro-bad-alloc-02-no-op-new-nt.C: Likewise. >>> * >>> testsuite/g++.dg/coroutines/coro-bad-grooaf-01-grooaf-expected.C: >>> Likewise. >>> * testsuite/g++.dg/coroutines/pr97438.C: Likewise. >>> * testsuite/g++.dg/coroutines/ramp-return-b.C: Likewise. >>> >>> Tested under Linux x86_64. >>> >>> I'm contributing to libstdc++ so I already have write access. >>> >>> Ok to commit ? >>> >>> François --------------oy3uM3ZeK0KsH0ns9AFZv2t1 Content-Type: text/x-patch; charset=UTF-8; name="coroutines_tests.patch" Content-Disposition: attachment; filename="coroutines_tests.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZysrLmRnL2Nvcm91dGluZXMvY29yby1iYWQt YWxsb2MtMDAtYmFkLW9wLW5ldy5DIGIvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvY29yb3V0aW5l cy9jb3JvLWJhZC1hbGxvYy0wMC1iYWQtb3AtbmV3LkMKaW5kZXggNDcwNmRlZWJmNGUuLjky OGUwYzk3NGUxIDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2crKy5kZy9jb3JvdXRpbmVz L2Nvcm8tYmFkLWFsbG9jLTAwLWJhZC1vcC1uZXcuQworKysgYi9nY2MvdGVzdHN1aXRlL2cr Ky5kZy9jb3JvdXRpbmVzL2Nvcm8tYmFkLWFsbG9jLTAwLWJhZC1vcC1uZXcuQwpAQCAtNiw3 ICs2LDcgQEAKICNpbmNsdWRlICJjb3JvMS1hbGxvY2F0b3JzLmgiCiAKIHN0cnVjdCBjb3Jv MQotZiAoKSAgLyogeyBkZy1lcnJvciB7J29wZXJhdG9yIG5ldycgaXMgcHJvdmlkZWQgYnkg J3N0ZDo6X19uNDg2MTo6X19jb3JvdXRpbmVfdHJhaXRzX2ltcGw8Y29ybzEsIHZvaWQ+Ojpw cm9taXNlX3R5cGUnIFx7YWthICdjb3JvMTo6cHJvbWlzZV90eXBlJ1x9IGJ1dCBpcyBub3Qg dXNhYmxlIHdpdGggdGhlIGZ1bmN0aW9uIHNpZ25hdHVyZSAnY29ybzEgZlwoXCknfSB9ICov CitmICgpICAvKiB7IGRnLWVycm9yIHsnb3BlcmF0b3IgbmV3JyBpcyBwcm92aWRlZCBieSAn c3RkOjooX184OjopP19fbjQ4NjE6Ol9fY29yb3V0aW5lX3RyYWl0c19pbXBsPGNvcm8xLCB2 b2lkPjo6cHJvbWlzZV90eXBlJyBce2FrYSAnY29ybzE6OnByb21pc2VfdHlwZSdcfSBidXQg aXMgbm90IHVzYWJsZSB3aXRoIHRoZSBmdW5jdGlvbiBzaWduYXR1cmUgJ2Nvcm8xIGZcKFwp J30gfSAqLwogewogICBjb19yZXR1cm47CiB9CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRl L2crKy5kZy9jb3JvdXRpbmVzL2Nvcm8tYmFkLWFsbG9jLTAxLWJhZC1vcC1kZWwuQyBiL2dj Yy90ZXN0c3VpdGUvZysrLmRnL2Nvcm91dGluZXMvY29yby1iYWQtYWxsb2MtMDEtYmFkLW9w LWRlbC5DCmluZGV4IDI1MmNiNWU0NDJjLi42YmVkNTI0YWEwYSAxMDA2NDQKLS0tIGEvZ2Nj L3Rlc3RzdWl0ZS9nKysuZGcvY29yb3V0aW5lcy9jb3JvLWJhZC1hbGxvYy0wMS1iYWQtb3At ZGVsLkMKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvY29yb3V0aW5lcy9jb3JvLWJhZC1h bGxvYy0wMS1iYWQtb3AtZGVsLkMKQEAgLTYsNyArNiw3IEBACiAjaW5jbHVkZSAiY29ybzEt YWxsb2NhdG9ycy5oIgogCiBzdHJ1Y3QgY29ybzEKLWYgKCkgIC8qIHsgZGctZXJyb3Igeydv cGVyYXRvciBkZWxldGUnIGlzIHByb3ZpZGVkIGJ5ICdzdGQ6Ol9fbjQ4NjE6Ol9fY29yb3V0 aW5lX3RyYWl0c19pbXBsPGNvcm8xLCB2b2lkPjo6cHJvbWlzZV90eXBlJyBce2FrYSAnY29y bzE6OnByb21pc2VfdHlwZSdcfSBidXQgaXMgbm90IHVzYWJsZSB3aXRoIHRoZSBmdW5jdGlv biBzaWduYXR1cmUgJ2Nvcm8xIGZcKFwpJ30gfSAqLworZiAoKSAgLyogeyBkZy1lcnJvciB7 J29wZXJhdG9yIGRlbGV0ZScgaXMgcHJvdmlkZWQgYnkgJ3N0ZDo6KF9fODo6KT9fX240ODYx OjpfX2Nvcm91dGluZV90cmFpdHNfaW1wbDxjb3JvMSwgdm9pZD46OnByb21pc2VfdHlwZScg XHtha2EgJ2Nvcm8xOjpwcm9taXNlX3R5cGUnXH0gYnV0IGlzIG5vdCB1c2FibGUgd2l0aCB0 aGUgZnVuY3Rpb24gc2lnbmF0dXJlICdjb3JvMSBmXChcKSd9IH0gKi8KIHsKICAgY29fcmV0 dXJuOwogfQpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvY29yb3V0aW5lcy9j b3JvLWJhZC1hbGxvYy0wMi1uby1vcC1uZXctbnQuQyBiL2djYy90ZXN0c3VpdGUvZysrLmRn L2Nvcm91dGluZXMvY29yby1iYWQtYWxsb2MtMDItbm8tb3AtbmV3LW50LkMKaW5kZXggODk5 NzJiNjA5NDUuLjBhNTQ1ZmVkMGUzIDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2crKy5k Zy9jb3JvdXRpbmVzL2Nvcm8tYmFkLWFsbG9jLTAyLW5vLW9wLW5ldy1udC5DCisrKyBiL2dj Yy90ZXN0c3VpdGUvZysrLmRnL2Nvcm91dGluZXMvY29yby1iYWQtYWxsb2MtMDItbm8tb3At bmV3LW50LkMKQEAgLTksNyArOSw3IEBACiAjaW5jbHVkZSAiY29ybzEtYWxsb2NhdG9ycy5o IgogCiBzdHJ1Y3QgY29ybzEKLWYgKCkgLyogeyBkZy1lcnJvciB7J2Nvcm8xOjpwcm9taXNl X3R5cGU6OmdldF9yZXR1cm5fb2JqZWN0X29uX2FsbG9jYXRpb25fZmFpbHVyZVwoXClcKFwp JyBpcyBwcm92aWRlZCBieSAnc3RkOjpfX240ODYxOjpfX2Nvcm91dGluZV90cmFpdHNfaW1w bDxjb3JvMSwgdm9pZD46OnByb21pc2VfdHlwZScgXHtha2EgJ2Nvcm8xOjpwcm9taXNlX3R5 cGUnXH0gYnV0ICdvcGVyYXRvciBuZXcnIGlzIG5vdCBtYXJrZWQgJ3Rocm93XChcKScgb3Ig J25vZXhjZXB0J30gfSAqLworZiAoKSAvKiB7IGRnLWVycm9yIHsnY29ybzE6OnByb21pc2Vf dHlwZTo6Z2V0X3JldHVybl9vYmplY3Rfb25fYWxsb2NhdGlvbl9mYWlsdXJlXChcKVwoXCkn IGlzIHByb3ZpZGVkIGJ5ICdzdGQ6OihfXzg6Oik/X19uNDg2MTo6X19jb3JvdXRpbmVfdHJh aXRzX2ltcGw8Y29ybzEsIHZvaWQ+Ojpwcm9taXNlX3R5cGUnIFx7YWthICdjb3JvMTo6cHJv bWlzZV90eXBlJ1x9IGJ1dCAnb3BlcmF0b3IgbmV3JyBpcyBub3QgbWFya2VkICd0aHJvd1wo XCknIG9yICdub2V4Y2VwdCd9IH0gKi8KIHsKICAgY29fcmV0dXJuOwogfQpkaWZmIC0tZ2l0 IGEvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvY29yb3V0aW5lcy9jb3JvLWJhZC1ncm9vYWYtMDEt Z3Jvb2FmLWV4cGVjdGVkLkMgYi9nY2MvdGVzdHN1aXRlL2crKy5kZy9jb3JvdXRpbmVzL2Nv cm8tYmFkLWdyb29hZi0wMS1ncm9vYWYtZXhwZWN0ZWQuQwppbmRleCA5ZmEzZDY0YTlmMi4u YjM2ZTg4Zjg3MWEgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUvZysrLmRnL2Nvcm91dGlu ZXMvY29yby1iYWQtZ3Jvb2FmLTAxLWdyb29hZi1leHBlY3RlZC5DCisrKyBiL2djYy90ZXN0 c3VpdGUvZysrLmRnL2Nvcm91dGluZXMvY29yby1iYWQtZ3Jvb2FmLTAxLWdyb29hZi1leHBl Y3RlZC5DCkBAIC02LDcgKzYsNyBAQAogaW50IHVzZWRfZ3Jvb2FmID0gMDsKIAogc3RydWN0 IGNvcm8xCi1mICgpIG5vZXhjZXB0IC8vIHsgZGctd2FybmluZyB7J29wZXJhdG9yIG5ldycg aXMgbWFya2VkICd0aHJvd1woXCknIG9yICdub2V4Y2VwdCcgYnV0IG5vIHVzYWJsZSAnZ2V0 X3JldHVybl9vYmplY3Rfb25fYWxsb2NhdGlvbl9mYWlsdXJlJyBpcyBwcm92aWRlZCBieSAn c3RkOjpfX240ODYxOjpfX2Nvcm91dGluZV90cmFpdHNfaW1wbDxjb3JvMSwgdm9pZD46OnBy b21pc2VfdHlwZScgXHtha2EgJ2Nvcm8xOjpwcm9taXNlX3R5cGUnXH19IH0KK2YgKCkgbm9l eGNlcHQgLy8geyBkZy13YXJuaW5nIHsnb3BlcmF0b3IgbmV3JyBpcyBtYXJrZWQgJ3Rocm93 XChcKScgb3IgJ25vZXhjZXB0JyBidXQgbm8gdXNhYmxlICdnZXRfcmV0dXJuX29iamVjdF9v bl9hbGxvY2F0aW9uX2ZhaWx1cmUnIGlzIHByb3ZpZGVkIGJ5ICdzdGQ6OihfXzg6Oik/X19u NDg2MTo6X19jb3JvdXRpbmVfdHJhaXRzX2ltcGw8Y29ybzEsIHZvaWQ+Ojpwcm9taXNlX3R5 cGUnIFx7YWthICdjb3JvMTo6cHJvbWlzZV90eXBlJ1x9fSB9CiB7CiAgIFBSSU5UICgiY29y bzE6IGFib3V0IHRvIHJldHVybiIpOwogICBjb19yZXR1cm47CmRpZmYgLS1naXQgYS9nY2Mv dGVzdHN1aXRlL2crKy5kZy9jb3JvdXRpbmVzL3ByOTc0MzguQyBiL2djYy90ZXN0c3VpdGUv ZysrLmRnL2Nvcm91dGluZXMvcHI5NzQzOC5DCmluZGV4IDk1Mzc2NjQ4ZWQ3Li5hYzM3MTE4 ZWFlNyAxMDA2NDQKLS0tIGEvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvY29yb3V0aW5lcy9wcjk3 NDM4LkMKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvY29yb3V0aW5lcy9wcjk3NDM4LkMK QEAgLTI1LDYgKzI1LDYgQEAgcHVibGljOgogfQogCiBkdW1teV9jb3JvdXRpbmUKLWZvbygp IHsgLy8geyBkZy1lcnJvciB7dGhlIGNvcm91dGluZSBwcm9taXNlIHR5cGUgJ3N0ZDo6X19u NDg2MTo6Y29yb3V0aW5lX3RyYWl0czxkdW1teV9jb3JvdXRpbmU+Ojpwcm9taXNlX3R5cGUn IGRlY2xhcmVzIGJvdGggJ3JldHVybl92YWx1ZScgYW5kICdyZXR1cm5fdm9pZCd9IH0KK2Zv bygpIHsgLy8geyBkZy1lcnJvciB7dGhlIGNvcm91dGluZSBwcm9taXNlIHR5cGUgJ3N0ZDo6 KF9fODo6KT9fX240ODYxOjpjb3JvdXRpbmVfdHJhaXRzPGR1bW15X2Nvcm91dGluZT46OnBy b21pc2VfdHlwZScgZGVjbGFyZXMgYm90aCAncmV0dXJuX3ZhbHVlJyBhbmQgJ3JldHVybl92 b2lkJ30gfQogICAgIGNvX3JldHVybiAxNzsKIH0KZGlmZiAtLWdpdCBhL2djYy90ZXN0c3Vp dGUvZysrLmRnL2Nvcm91dGluZXMvcmFtcC1yZXR1cm4tYi5DIGIvZ2NjL3Rlc3RzdWl0ZS9n KysuZGcvY29yb3V0aW5lcy9yYW1wLXJldHVybi1iLkMKaW5kZXggZDBlNWQxZjNjN2YuLmZj Y2ExZDczYTAyIDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2crKy5kZy9jb3JvdXRpbmVz L3JhbXAtcmV0dXJuLWIuQworKysgYi9nY2MvdGVzdHN1aXRlL2crKy5kZy9jb3JvdXRpbmVz L3JhbXAtcmV0dXJuLWIuQwpAQCAtMTksNCArMTksNCBAQCB0YXNrPHN0ZDo6dmVjdG9yPGlu dD4+CiBiYXogKCkKIHsKICAgY29fcmV0dXJuIHN0ZDo6dmVjdG9yPGludD4oKTsKLX0gLy8g eyBkZy1lcnJvciB7dXNlIG9mIGRlbGV0ZWQgZnVuY3Rpb24gJ3Rhc2s8VD46OnRhc2tcKGNv bnN0IHRhc2s8VD4mXCkgXFt3aXRoIFQgPSBzdGQ6OnZlY3RvcjxpbnQ+XF0nfSB9Cit9IC8v IHsgZGctZXJyb3Ige3VzZSBvZiBkZWxldGVkIGZ1bmN0aW9uICd0YXNrPFQ+Ojp0YXNrXChj b25zdCB0YXNrPFQ+JlwpIFxbd2l0aCBUID0gc3RkOjooX184OjopP3ZlY3RvcjxpbnQ+XF0n fSB9Cg== --------------oy3uM3ZeK0KsH0ns9AFZv2t1--