From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id A79473858401; Wed, 23 Aug 2023 17:35:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A79473858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99bdeae1d0aso780450866b.1; Wed, 23 Aug 2023 10:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692812124; x=1693416924; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=j40STO78eDZRO/CVDb3zfibUieKJWZLQ3TE1c4i87kg=; b=jO1PLRFNgSqfHBio7oZz3ICxf/dkTRsZsiUqWDHB20kaegWfTYs7GU0vuINoRb4LJQ WyzTT/kqqAFDtq7jfmQxnqoHatuuTFdaLR/Z2JpBWJk6d/Kf/MRqH3T7N/uOdvgn1eio MllDPl/jvK3aYhPb2T8Skknt1T71wFobmyjZ03vvP1gj/ZFQkOBYmTM0w6qrO0yf6urT MjOT2Xk9qd0DhkLvFQCwEbJVItsS5QY4C3XYpjwEQZMdCIZuqDc3sYGZjzw//64QKt/d Ju+JIiaS2HrAdgp3j9WRRpJ3/x7Tm9WMkn7b6pow2fcKzp4kKOofvEPhTARY3ThhVZ45 dazQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692812124; x=1693416924; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j40STO78eDZRO/CVDb3zfibUieKJWZLQ3TE1c4i87kg=; b=Gopik/fjFnr9h1fFrx7NVLDJZbGVaue9xrrp5/1fHIO0qhQRtVfNycz7E2obZiP5OD tx8p/jzaJVJOnlsJ0MhKhdVrVhPKgkLkRHkhwszLgDmfjeNTfkNSsciVNLvX+Ufktsc2 UGVTe90MKkhD8neBsBxAsQ4mpG4fvl3hRpZYDjIGlVd8OjPQTy4hDJ9L3lPSztkwBujP gggCkM6l7GaGxtefHL4GF+Jyjr0mL71w8xCNS8TJx/wtQhInkPXZZK+fnvjoXrGtm+a6 JEJ9Uvuh91daItD/trmwtYCqH3K19+ezJxlMUeclKHqQ8STp/c9z/y610IU236N468nA 2KsQ== X-Gm-Message-State: AOJu0Yzr6CnGeaN3hw5u90kzo8WaexDDudmG4k5pCveRit92T6jjURyO np35tRZEynfEKUXWSTL7b6XgF/U7cPw= X-Google-Smtp-Source: AGHT+IE6yvBeIwNzW7pUoZiAdSC1tAFKW/bpQ0wVJpOR91m0Prky9cQVQfGR8dt2yFpYXBctjCAU3w== X-Received: by 2002:a17:906:7485:b0:9a1:c44d:7056 with SMTP id e5-20020a170906748500b009a1c44d7056mr4105716ejl.26.1692812123511; Wed, 23 Aug 2023 10:35:23 -0700 (PDT) Received: from [10.5.1.95] ([89.207.171.94]) by smtp.gmail.com with ESMTPSA id i6-20020a170906698600b009928b4e3b9fsm10000795ejr.114.2023.08.23.10.35.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Aug 2023 10:35:22 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------IcwDZWNRuNipIHU0kRiKvKVd" Message-ID: Date: Wed, 23 Aug 2023 19:35:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: libstdc++ Cc: gcc-patches From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Subject: [PATCH][_GLIBCXX_INLINE_VERSION] Fix friend declarations X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------IcwDZWNRuNipIHU0kRiKvKVd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi The few tests that are failing in versioned namespace mode are due to those friend declarations. This is a fix proposal even if I considered 2 other options: 1. Make __format::_Arg_store a struct and so do not bother with friend declarations. 2. Consider it as a compiler bug and do nothing. In this case I think we might still need this patch to avoid a non-working format library in versioned namespace mode in gcc 14 if compiler bug is not fixed. I can also define _GLIBCXX_STD_V at level to limit impact.     libstdc++: [_GLIBCXX_INLINE_VERSION] Fix friend declarations     GCC do not consider the inline namespace in friend declarations. We need     to explicit this namespace.     libstdc++-v3/ChangeLog:             * include/bits/c++config (_GLIBCXX_STD_V): New macro giving current             std namespace with optionally the version namespace.             * include/std/format (std::__format::_Arg_store): Use latter on friend             declarations. Tested under versioned mode. Ok to commit ? François --------------IcwDZWNRuNipIHU0kRiKvKVd Content-Type: text/x-patch; charset=UTF-8; name="version_ns_format.patch" Content-Disposition: attachment; filename="version_ns_format.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL2JpdHMvYysrY29uZmlnIGIvbGli c3RkYysrLXYzL2luY2x1ZGUvYml0cy9jKytjb25maWcKaW5kZXggMGE0MWNkZDI5YTkuLmE5 MTdmYjU4MjI1IDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvaW5jbHVkZS9iaXRzL2MrK2Nv bmZpZworKysgYi9saWJzdGRjKystdjMvaW5jbHVkZS9iaXRzL2MrK2NvbmZpZwpAQCAtNDQ5 LDYgKzQ0OSw3IEBAIF9HTElCQ1hYX0VORF9OQU1FU1BBQ0VfVkVSU0lPTgogLy8gb2Ygc29t ZSBuZXN0ZWQgbmFtZXNwYWNlIHdpdGhpbiBpdCBjb3JyZXNwb25kaW5nIHRvIHRoZSBhY3Rp dmUgbW9kZS4KIC8vIF9HTElCQ1hYX1NURF9BCiAvLyBfR0xJQkNYWF9TVERfQworLy8gX0dM SUJDWFhfU1REX1YKIC8vCiAvLyBNYWNyb3MgZm9yIG9wZW5pbmcvY2xvc2luZyBjb25kaXRp b25hbCBuYW1lc3BhY2VzLgogLy8gX0dMSUJDWFhfQkVHSU5fTkFNRVNQQUNFX0FMR08KQEAg LTQ3Nyw2ICs0NzgsMTIgQEAgX0dMSUJDWFhfRU5EX05BTUVTUEFDRV9WRVJTSU9OCiAjIGRl ZmluZSBfR0xJQkNYWF9FTkRfTkFNRVNQQUNFX0FMR08KICNlbmRpZgogCisjaWYgX0dMSUJD WFhfSU5MSU5FX1ZFUlNJT04KKyMgZGVmaW5lIF9HTElCQ1hYX1NURF9WIHN0ZDo6X184Cisj ZWxzZQorIyBkZWZpbmUgX0dMSUJDWFhfU1REX1Ygc3RkCisjZW5kaWYKKwogLy8gR0xJQkNY WF9BQkkgRGVwcmVjYXRlZAogLy8gRGVmaW5lIGlmIGNvbXBhdGliaWxpdHkgc2hvdWxkIGJl IHByb3ZpZGVkIGZvciAtbWxvbmctZG91YmxlLTY0LgogI3VuZGVmIF9HTElCQ1hYX0xPTkdf RE9VQkxFX0NPTVBBVApkaWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL2luY2x1ZGUvc3RkL2Zv cm1hdCBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC9mb3JtYXQKaW5kZXggZjNkOWFlMTUy ZjkuLjk0NDE3YzMyMWU0IDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvaW5jbHVkZS9zdGQv Zm9ybWF0CisrKyBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC9mb3JtYXQKQEAgLTM0Mjks MTEgKzM0MjksMTEgQEAgbmFtZXNwYWNlIF9fZm9ybWF0CiAgIHRlbXBsYXRlPHR5cGVuYW1l IF9Db250ZXh0LCB0eXBlbmFtZS4uLiBfQXJncz4KICAgICBjbGFzcyBfX2Zvcm1hdDo6X0Fy Z19zdG9yZQogICAgIHsKLSAgICAgIGZyaWVuZCBzdGQ6OmJhc2ljX2Zvcm1hdF9hcmdzPF9D b250ZXh0PjsKKyAgICAgIGZyaWVuZCBfR0xJQkNYWF9TVERfVjo6YmFzaWNfZm9ybWF0X2Fy Z3M8X0NvbnRleHQ+OwogCiAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBfQ3R4LCB0eXBlbmFt ZS4uLiBfQXJnej4KIAlmcmllbmQgYXV0bwotCXN0ZDo6bWFrZV9mb3JtYXRfYXJncyhfQXJn eiYmLi4uKSBub2V4Y2VwdDsKKwlfR0xJQkNYWF9TVERfVjo6bWFrZV9mb3JtYXRfYXJncyhf QXJneiYmLi4uKSBub2V4Y2VwdDsKIAogICAgICAgLy8gRm9yIGEgc3VmZmljaWVudGx5IHNt YWxsIG51bWJlciBvZiBhcmd1bWVudHMgd2Ugb25seSBzdG9yZSB2YWx1ZXMuCiAgICAgICAv LyBiYXNpY19mb3JtYXRfYXJncyBjYW4gZ2V0IHRoZSB0eXBlcyBmcm9tIHRoZSBfQXJncyBw YWNrLgo= --------------IcwDZWNRuNipIHU0kRiKvKVd--