From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id C63D03858C98; Wed, 27 Mar 2024 10:07:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C63D03858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C63D03858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711534038; cv=none; b=XgaRjUO+fHJyncv6FOEYWNzMCm4jyF+qcYzYrFJ3UTn4QW9o0HCeZiIt2mksfThjHRt3eXtA7hK4Uu0y9TNzZ/mNsZYZd3c8VpFQ5IJsycqTWSZWE0/YeDwhy3IIOiCDqc1zYyAV6cgG3K9kDw5PdS8Cx4JCepoetQ8h6QeX4Y4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711534038; c=relaxed/simple; bh=m6cP2BFkvH3nlv2gSizYoAtfCjwvlLEfH6uuRMeMLN0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=n4qC3t/e5CQHXuHaL80NplTslPq3nxI1Rfoht+15TvP1JkYliyDvl60XWWX/FnssQAj6Z8wuBm0LKJ4VwOCspMbqMkMkgCbldnT1M7CKnlxcuQzhOuC2WBfQRgIT75BCzlREmPQX/xem538oGmT41GwMui77Avqe4PvsgwL9ugs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E31E2F4; Wed, 27 Mar 2024 03:07:50 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 98E293F694; Wed, 27 Mar 2024 03:07:15 -0700 (PDT) From: Richard Sandiford To: Jonathan Wakely Mail-Followup-To: Jonathan Wakely ,Matthias Kretz , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, Srinivas Yadav Singanaboina , richard.sandiford@arm.com Cc: Matthias Kretz , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, Srinivas Yadav Singanaboina Subject: Re: [PATCH v2] libstdc++: add ARM SVE support to std::experimental::simd References: <20240209142810.97817-1-vasu.srinivasvasu.14@gmail.com> <5282839.4XsnlVU6TS@minbar> Date: Wed, 27 Mar 2024 10:07:14 +0000 In-Reply-To: (Jonathan Wakely's message of "Wed, 27 Mar 2024 09:50:41 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jonathan Wakely writes: > On Fri, 8 Mar 2024 at 09:58, Matthias Kretz wrote: >> >> Hi, >> >> I applied and did extended testing on x86_64 (no regressions) and aarch64 >> using qemu testing SVE 256, 512, and 1024. Looks good! >> >> While going through the applied patch I noticed a few style issues that I >> simply turned into a patch (attached). >> > [...] >> >> From my side, with the noted changes the patch is ready for merging. >> @Jonathan, any chance for a green light before GCC 14.1? > > As discussed on IRC, please push the revised patch with your > suggestions incorporated (and post to the lists for posterity). > > Thanks, everybody, for the patches and the thorough review. I'm still worried about: #if _GLIBCXX_SIMD_HAVE_SVE constexpr inline int __sve_vectorized_size_bytes = __ARM_FEATURE_SVE_BITS / 8; #else constexpr inline int __sve_vectorized_size_bytes = 0; #endif and the direct use __ARM_FEATURE_SVE_BITS elsewhere, for the reasons discussed here (including possible ODR problems): https://gcc.gnu.org/pipermail/gcc-patches/2023-December/640037.html https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643734.html Logically the vector length should be a template parameter rather than an invariant. Has this been resolved? If not, it feels like a blocker to me (sorry). Thanks, Richard