Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

[Alexandre Oliva <oliva@adacore.com>]

On Jul  5, 2022, Jonathan Wakely <jwakely@redhat.com> wrote:

> The cast itself is fine, but I'd like a comment like "N.B. pid_t is a
> pointer on vxworks" so I don't "simplify" it again.


libstdc++: testsuite: why cast getpid result

Add a comment next to the getpid call to explain why the typecast is
needed.

Regstrapped on x86_64-linux-gnu, will install later today if there's no
objection.


for  libstdc++-v3/ChangeLog

	* testsuite/util/testsuite_fs (nonexistent_path): Explain why
	we need the typecast.
---
 libstdc++-v3/testsuite/util/testsuite_fs.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/util/testsuite_fs.h b/libstdc++-v3/testsuite/util/testsuite_fs.h
index 25f8f734dc792..0e28385e99aca 100644
--- a/libstdc++-v3/testsuite/util/testsuite_fs.h
+++ b/libstdc++-v3/testsuite/util/testsuite_fs.h
@@ -162,7 +162,8 @@ namespace __gnu_test
     if (file.length() > 64)
       file.resize(64);
     // The combination of random counter and PID should be unique for a given
-    // run of the testsuite.
+    // run of the testsuite.  N.B. getpid() returns a pointer type on vxworks
+    // in kernel mode.
     file += std::to_string((unsigned long) ::getpid());
     p = std::move(file);
     if (test_fs::exists(p))


-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>