public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <oliva@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: async: tolerate slightly shorter sleep
Date: Thu, 23 Jun 2022 08:36:21 -0300	[thread overview]
Message-ID: <ora6a34nnu.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <orzgi59qvw.fsf@lxoliva.fsfla.org> (Alexandre Oliva's message of "Wed, 22 Jun 2022 03:03:15 -0300")

On Jun 22, 2022, Alexandre Oliva <oliva@adacore.com> wrote:

> Regstrapped on x86_64-linux-gnu, also tested with a cross to
> aarch64-rtems6.  Ok to install?

The early wakeups are fixed for rtems6.1, so the same question raised at
https://gcc.gnu.org/pipermail/gcc-patches/2022-June/597102.html apply to
this one:

libstdc++: xfail nanosleep tests on rtems

From: Alexandre Oliva <oliva@adacore.com>

Since it has been determined that nanosleep may return slightly too
early on RTEMS, due to clock resolution differences, expect
30_thread/async tests that have detected too-early wakeups to fail on
RTEMS targets.


for  libstdc++-v3/ChangeLog

	* testsuite/30_threads/async/async.cc: xfail on RTEMS.

TN: V608-048
---
 libstdc++-v3/testsuite/30_threads/async/async.cc |    1 +
 1 file changed, 1 insertion(+)

diff --git a/libstdc++-v3/testsuite/30_threads/async/async.cc b/libstdc++-v3/testsuite/30_threads/async/async.cc
index 38943ff1a9a5e..e0b731186c459 100644
--- a/libstdc++-v3/testsuite/30_threads/async/async.cc
+++ b/libstdc++-v3/testsuite/30_threads/async/async.cc
@@ -2,6 +2,7 @@
 // { dg-additional-options "-pthread" { target pthread } }
 // { dg-require-effective-target c++11 }
 // { dg-require-gthreads "" }
+// { dg-xfail-if "nanosleep may wake up too early" { *-*-rtems* } }
 
 // Copyright (C) 2010-2022 Free Software Foundation, Inc.
 //


-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>

  reply	other threads:[~2022-06-23 11:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  6:03 Alexandre Oliva
2022-06-23 11:36 ` Alexandre Oliva [this message]
2022-10-12 11:41   ` Jonathan Wakely
2022-10-12 11:45     ` Jonathan Wakely
2022-10-12 21:11       ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ora6a34nnu.fsf@lxoliva.fsfla.org \
    --to=oliva@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).