public inbox for
 help / color / mirror / Atom feed
From: Alexandre Oliva <>
Subject: [PATCH] libstdc++-v3: testsuite: complex proj requirements
Date: Tue, 21 Jun 2022 02:39:37 -0300	[thread overview]
Message-ID: <> (raw)

The template version of complex::proj returns its argument without
testing for infinities, and that's all we have when neither C99
complex nor C99 math functions are available, and it seems too hard to
do better without isinf and copysign.

I suppose just calling them and expecting users will supply
specializations as needed has been ruled out, and so has refraining
from defining it when it can't be implemented correctly.

It's pointless to run the test under these circumstances, so
arrange for it to be skipped.  In an unusual way, after trying to
introduce dg-require tests for ccomplex-or-cmath, and found their
results to be misleading due to variations across -std=* versions.

Regstrapped on x86_64-linux-gnu, also tested with a cross to
aarch64-rtems6.  Ok to install?

for  libstdc++-v3/ChangeLog

	* testsuite/26_numerics/complex/ Skip test in the
	circumstances in which the implementation of proj is known to
	be broken.
 libstdc++-v3/testsuite/26_numerics/complex/ |   13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/libstdc++-v3/testsuite/26_numerics/complex/ b/libstdc++-v3/testsuite/26_numerics/complex/
index a053119197ccd..69f8153c06f05 100644
--- a/libstdc++-v3/testsuite/26_numerics/complex/
+++ b/libstdc++-v3/testsuite/26_numerics/complex/
@@ -397,6 +397,19 @@ test03()
+  /* If neither of these macros is nonzero, proj calls a
+     specialization of the __complex_proj template, that just returns
+     its argument, without testing for infinities, rendering the whole
+     test pointless, and failing (as intended/noted in the
+     implementation) the cases that involve infinities.  Alas, the
+     normal ways to skip tests may not work: we don't have a test for
+     C99_COMPLEX, and these macros may vary depending on -std=*, but
+     macro tests wouldn't take them into account.  */
+  if (true)
+    return 0;

Alexandre Oliva, happy hacker      
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <>

             reply	other threads:[~2022-06-21  5:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21  5:39 Alexandre Oliva [this message]
2022-06-27 10:08 ` Alexandre Oliva
2022-06-27 10:12   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).