From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id DB165385782D; Fri, 15 Jan 2021 16:19:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DB165385782D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oliva@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id ADCB7562A1; Fri, 15 Jan 2021 11:19:02 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Z71xbJ2n59qR; Fri, 15 Jan 2021 11:19:02 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 6E176562A4; Fri, 15 Jan 2021 11:19:02 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 10FGIrPB266266 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Jan 2021 13:18:55 -0300 From: Alexandre Oliva To: Jonathan Wakely Cc: Jonathan Wakely , "libstdc++" , gcc-patches@gcc.gnu.org, Corentin Gay Subject: Re: Add dg-require-wchars to libstdc++ testsuite Organization: Free thinker, does not speak for AdaCore References: <20210114134142.GC7692@redhat.com> Errors-To: aoliva@lxoliva.fsfla.org Date: Fri, 15 Jan 2021 13:18:53 -0300 In-Reply-To: (Jonathan Wakely's message of "Fri, 15 Jan 2021 10:09:46 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2021 16:19:04 -0000 On Jan 15, 2021, Jonathan Wakely wrote: > On Thu, 14 Jan 2021, 22:22 Alexandre Oliva, wrote: >> ... it is definitely the case that the target currently defines wchar_t, >> and it even offers wchar.h and a lot of (maybe all?) wcs* functions. >> This was likely not the case when the patch was first written. >> >> I'll double check whether any of the patch is still needed for current >> versions. With the tests I've run since yesterday, I've determined that: - the wchar-related patches for the libstdc++ testsuite, that I had proposed last year, are no longer needed - your two patchlets did not bring about any regressions to test results, not in mainline x86_64-linux-gnu native, not with the trivial backports to the gcc-10 tree for x-arm-vxw7r2 that was the focus of my immediate attention. So, I withdraw my submissions of the testsuite patches, and I encourage you to proceed with the two changes you proposed. However, for avoidance of any doubt, I'll restate that I cannot vow for whether they're enough to fix the issues we'd run into back when wchar/wcs* were not supported in the target system, because now they are, so the changes do not bring any visible improvements to our results either. Anyway, thanks for the feedback! -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar