From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTPS id 8FB523858D1E; Fri, 29 Apr 2022 01:53:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8FB523858D1E Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4C3811163D2; Thu, 28 Apr 2022 21:53:52 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ykic4nuLl8Vx; Thu, 28 Apr 2022 21:53:52 -0400 (EDT) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id D152D116292; Thu, 28 Apr 2022 21:53:51 -0400 (EDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 23T1reNl2573168 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Apr 2022 22:53:41 -0300 From: Alexandre Oliva To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, David Edelsohn Subject: Re: [PATCH] libstdc++: ppc: conditionalize vsx-only simd intrinsics Organization: Free thinker, does not speak for AdaCore References: <20220428130306.GS25951@gate.crashing.org> Errors-To: aoliva@lxoliva.fsfla.org Date: Thu, 28 Apr 2022 22:53:40 -0300 In-Reply-To: <20220428130306.GS25951@gate.crashing.org> (Segher Boessenkool's message of "Thu, 28 Apr 2022 08:03:06 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 01:53:54 -0000 On Apr 28, 2022, Segher Boessenkool wrote: > On Thu, Apr 28, 2022 at 03:09:54AM -0300, Alexandre Oliva wrote: >> +# ifdef __VSX__ > No space after # (here and everywhere else). 'k, thanks >> + "no __intrinsic_type support for [long] double on PPC w/o VSX"); > This change isn't in the changelog. It is, it's just that long double is dealt with differently from the other types, so requiring VSX for it takes a different form: > * include/experimental/bits/simd.h [__ALTIVEC__]: Require VSX > for double, long long, and 64-bit long and 64-bit long double > intrinsic types. ^^^^^^^^^^^^^^^^^^ > The message should not say "long > double" without qualifying it as "64-bit long double". How about qualifying both such messages as in this incremental patchlet: @@ -2456,11 +2456,11 @@ template static constexpr bool _S_is_ldouble = is_same_v<_Tp, long double>; // allow _Tp == long double with -mlong-double-64 static_assert(!(_S_is_ldouble && sizeof(long double) > sizeof(double)), - "no __intrinsic_type support for long double on PPC"); + "no __intrinsic_type support for 128-bit floating point on PPC"); #ifndef __VSX__ static_assert(!(is_same_v<_Tp, double> || (_S_is_ldouble && sizeof(long double) == sizeof(double))), - "no __intrinsic_type support for [long] double on PPC w/o VSX"); + "no __intrinsic_type support for 64-bit floating point on PPC w/o VSX"); #endif using type = typename __intrinsic_type_impl< > Okay for trunk without this part of the patch, and the spaces after the > hash signs deleted. Or send a new patch with the "[long] double" thing > fixed? Thanks, awaiting feedback on the suggestion above to post the consolidated patch. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about