From: Alexandre Oliva <oliva@adacore.com>
To: "François Dumont" <frs.dumont@gmail.com>,
"Jonathan Wakely" <jwakely.gcc@gmail.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org,
Corentin Gay <gay@adacore.com>
Subject: Re: Add dg-require-wchars to libstdc++ testsuite
Date: Wed, 13 Jan 2021 14:29:17 -0300 [thread overview]
Message-ID: <orpn28oidu.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <orwnx9ilza.fsf@lxoliva.fsfla.org> (Alexandre Oliva's message of "Tue, 22 Dec 2020 18:12:25 -0300")
On Dec 28, 2020, François Dumont <frs.dumont@gmail.com> wrote:
> On 22/12/20 10:12 pm, Alexandre Oliva wrote:
>> Some tests uses structures from the libstdc++ that are present only if
>> the target has a wchar.h header. However, those tests do not check
>> that the target supports those constructs before executing the tests.
> Looks like those tests should be in some sub-folder containing
> 'wchar_t' to be considered as UNSUP.
> Maybe Jonathan will prefer them to be moved even if your approach
> seems more convenient to me.
I'd be glad to make such changes, but I'd appreciate stronger guidance
as to the preferences and the way to go before doing so. Jonathan,
would you please share your wisdom WRT this patch and the other
wchar_t-related libstdc++ testsuite one?
https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562435.html
https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562438.html
>> The function dg-require-wchars checks that "_GLIBCXX_USE_WCHAR_T" is
>> defined by the configure of the libstdc++. If it is not the case, the
>> test is not executed.
> This check_v3_target_wchars looks like a good candidate to leverage
> on: v3_check_preprocessor_condition.
Nice!, thanks for the tip, I was not aware of this proc.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
next prev parent reply other threads:[~2021-01-13 17:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 21:12 Alexandre Oliva
2020-12-28 18:23 ` François Dumont
2021-01-13 17:29 ` Alexandre Oliva [this message]
2021-01-14 13:08 ` Jonathan Wakely
2020-12-28 18:27 ` François Dumont
2021-01-14 13:41 ` Jonathan Wakely
2021-01-14 13:47 ` Add dg-require-wchars to libstdc++ testsuite# Jonathan Wakely
2021-01-14 22:20 ` Add dg-require-wchars to libstdc++ testsuite Alexandre Oliva
2021-01-15 10:09 ` Jonathan Wakely
2021-01-15 16:18 ` Alexandre Oliva
2021-01-15 19:47 ` Jonathan Wakely
2021-10-09 7:31 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orpn28oidu.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=frs.dumont@gmail.com \
--cc=gay@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).