From: Alexandre Oliva <oliva@adacore.com>
To: Matthias Kretz <m.kretz@gsi.de>
Cc: Matthias Kretz via Libstdc++ <libstdc++@gcc.gnu.org>,
<gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Correct NTTP and simd_mask ctor call
Date: Fri, 02 Jun 2023 06:30:17 -0300 [thread overview]
Message-ID: <orsfba1aae.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <4768566.iIbC2pHGDl@minbar> (Matthias Kretz's message of "Fri, 2 Jun 2023 10:50:33 +0200")
On Jun 2, 2023, Matthias Kretz <m.kretz@gsi.de> wrote:
> I'm looking at that function again, also in light of recent improvements wrt.
> code-gen, and will remove that assumption, that long long is vectorizable.
Thanks, I'll leave that to you, then.
I also noticed the same test is failing on rtems6 (at least with gcc
11). AFAICT the problem is that _GLIBCXX_SIMD_MATH_CALL* macros in
simd_math.h expect the named functions to be in std::, but I get such
errors as:
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1299: error: 'remainder' is not a member of 'std'
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1299: note: suggested alternatives:
[...]
.../aarch64-rtems6/include/math.h:346: note: 'remainder'
[...]
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1299: note: 'std::experimental::parallelism_v2::remainder'
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1299: error: template argument 1 is invalid
[...]
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1328: error: 'fmin' is not a member of 'std'; did you mean 'min'?
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1328: error: 'fmin' is not a member of 'std'; did you mean 'min'?
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1328: error: template argument 1 is invalid
ISTM that rtems is missing some of the math.h functions expected by
libstdc++, but also that even those that are present are not visible in
namespace ::std::, where the macros reasonably expect to find them. Is
this known? Should I file a PR about it?
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
next prev parent reply other threads:[~2023-06-02 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 11:10 Matthias Kretz
2023-05-26 15:46 ` Jonathan Wakely
2023-06-02 8:32 ` Alexandre Oliva
2023-06-02 8:50 ` Matthias Kretz
2023-06-02 9:30 ` Alexandre Oliva [this message]
2023-06-02 9:41 ` Matthias Kretz
2023-06-02 12:06 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orsfba1aae.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=m.kretz@gsi.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).