From: Alexandre Oliva <oliva@adacore.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: testsuite: call sched_yield for nonpreemptive targets
Date: Tue, 21 Jun 2022 21:20:43 -0300 [thread overview]
Message-ID: <orwnd9blb8.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <CACb0b4kA_eS7-ThvKLBXtNutREmuSewZ1FYpRdFWLaa-5tfsZg@mail.gmail.com> (Jonathan Wakely's message of "Tue, 21 Jun 2022 08:38:47 +0100")
On Jun 21, 2022, Jonathan Wakely <jwakely@redhat.com> wrote:
> On Tue, 21 Jun 2022 at 06:54, Alexandre Oliva via Libstdc++
> <libstdc++@gcc.gnu.org> wrote:
>>
>>
>> As in the gcc testsuite, systems without preemptive multi-threading
>> require sched_yield calls to be placed at points in which a context
>> switch might be needed to enable the test to complete.
> I'll try to remember that, but will probably forget. Is this really
> the only affected test?
Yeah, the only one in libstdc++-v3/testsuite, as of gcc-11, which is
what I've focused on for this project; I haven't gone through all fails
on master to make sure they're unrelated. (This is holding up some
filesystem-related patches, whose tests are failing for reasons not
present in gcc-11, and some of the forward-ports needed significant
rewriting.)
libstdc++ has plenty of threading tests, but they involve sleeping or
otherwise blocking, which offers a context switch opportunity even on
non-preemptive multithreading systems. It's busy waits that require a
sched_yield. The gcc testsuite has a handful of those; covered by a
separate patch also posted last night.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
prev parent reply other threads:[~2022-06-22 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 5:52 Alexandre Oliva
2022-06-21 7:38 ` Jonathan Wakely
2022-06-22 0:20 ` Alexandre Oliva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orwnd9blb8.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).