From: Alexandre Oliva <oliva@adacore.com>
To: Jonathan Wakely <jwakely@redhat.com>, Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libsupc++: try cxa_thread_atexit_impl at runtime
Date: Fri, 01 Dec 2023 17:40:43 -0300 [thread overview]
Message-ID: <ory1edwt9w.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <CACb0b4n3XjPv1YeBWE2FSqwhttfQis6LcKJU_3w91Ut8fpLWRw@mail.gmail.com> (Jonathan Wakely's message of "Thu, 9 Nov 2023 08:20:59 +0000")
On Nov 9, 2023, Jonathan Wakely <jwakely@redhat.com> wrote:
> On Thu, 9 Nov 2023 at 01:56, Alexandre Oliva <oliva@adacore.com> wrote:
>> g++.dg/tls/thread_local-order2.C fails when the toolchain is built for
>> a platform that lacks __cxa_thread_atexit_impl, even if the program is
>> built and run using that toolchain on a (later) platform that offers
>> __cxa_thread_atexit_impl.
>>
>> This patch adds runtime testing for __cxa_thread_atexit_impl on
>> platforms that support weak symbols.
>>
>> Regstrapped on x86_64-linux-gnu, also tested with gcc-13 on i686- and
>> x86_64-, and with ac_cv_func___cxa_thread_atexit_impl=no, that, on a
>> distro that lacks __cxa_thread_atexit in libc, forces the newly-added
>> code to be exercised, and that enabled thread_local-order2.C to pass
>> where the runtime libc has __cxa_thread_atexit_impl. Ok to install?
> Seems fine to me. Any objections, Jason?
Jason, ping?
https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635750.html
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
next prev parent reply other threads:[~2023-12-01 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 1:55 Alexandre Oliva
2023-11-09 8:20 ` Jonathan Wakely
2023-12-01 20:40 ` Alexandre Oliva [this message]
2023-12-01 20:41 ` Jason Merrill
[not found] ` <CAGWvny=8391BCUZF8eyYgP-NMoWM+qa6Yra6OGVVXuQNuAi9kw@mail.gmail.com>
[not found] ` <orr0k0rw0g.fsf@lxoliva.fsfla.org>
[not found] ` <or1qbzsxv9.fsf@lxoliva.fsfla.org>
2023-12-06 12:30 ` Thomas Schwinge
2023-12-06 13:52 ` Jonathan Wakely
2023-12-06 14:40 ` Jonathan Wakely
2023-12-06 22:46 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ory1edwt9w.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).