From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id C8B2B3858C2C for ; Fri, 1 Dec 2023 20:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C8B2B3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C8B2B3858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701463255; cv=none; b=l1SMLBm/loUAr0bLikKBEH1Zj8aASMivGGCtClkujqZusXFOzaSLifUgEmQINmMKUCIHv0fbDUBxbH2OX6Q1pGaGsQf/1wHWjQigm2nDNd1FOrG/oGgKx7DKIqNP2FpRA7/YhlKIhzm8aGuMwo+ACsrtKEzbbimnrYBjSYEZP3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701463255; c=relaxed/simple; bh=mtcuU2t+5O8hSQ2GPmPOuCrJ7Rx8MeXUVc8OjH5Ha0U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vaqPnc569PVc7jEaP7myC3sqnwYljS1Tj6kGUzbCVCWMQLU9geymyyYsIgaa+t/Hao/HzP1flUs6QPEE+WreSXx8nW6tlZzOaQ8SHs7gnSqGIj3P9ezz6ZzzFZbZVNh5iNf+wL6bCybDWndAwy/8uYdBfQe6je3kxvrYoc30eJ0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1d0521554ddso8576155ad.2 for ; Fri, 01 Dec 2023 12:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701463253; x=1702068053; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=/rmnUO288DIPKTSD9HVcAaYPeeHtyxsU75Ah6Q0ZDiQ=; b=W2L6qm1/M936BTtn2ZWKG2pA1aHrn4ggxIULX9sB06aSQO1PQYvPPYLEpBUSraBWdD 0ZB371lcnm9LnNsJp50K3Hvhrk1OXhMalPt1HZ3z8Rfbiz6mhsmYOwqHAVKR/oFhw+1A 7ipzRXCpuqe225wKkcLp9NeMzbG2LSHjfpx7CcrtaVkrHRasNY6+OrK0XurPF9oTWphW jWGh7lnZDvOCfe+WX3sEabWgLiUE89aH7L18XPFKjrbxAZ6cm63TxkKXrd7MOqTMOyXW Pa4TPnHy9VX4C1Jf1/LJbG2oQscFuL6gQWbUFjIn0ceMjmZQ2m5Objkc/D8N4uI4yVlX 9evg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701463253; x=1702068053; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/rmnUO288DIPKTSD9HVcAaYPeeHtyxsU75Ah6Q0ZDiQ=; b=Cn9AGUvkX4t9nS5FaY3hShr/JK8rxAQDpTkXCyYd+p8ghuRSAPrsNxGdjx3LSy3STr /Dxa08nJ5KkJ1RoaB1zwxJVtkYMQZqE3Mt45bxH9+uHjKLjQ1xdEZB/6hqBq0OI8RbBM wc/QKd1kKWzNakZ7XOopp04ECq5qCIfFUJdIKd79psaUrSNqOEJ2FGkOGgjNX/SkZxkd OcYKsFNnc/+PJCDVfH5CXZP22EFXTijMTSaaXOFbZhGx/+QGdyTuhwapq5XSVA9psdS8 Z/OVr4as6Y44b17Tk8HTopDAASenW+yOK4mJBzmeHdYyet/pgArA0/tY43yjCWEPIIyH VJgg== X-Gm-Message-State: AOJu0Ywh9b63SsG89PBZDENJKfnLex0b/qrbZ35zgkFQdfIk2wpMZkZh 5rsNJlRUna/Vsm8S+/hOpIXA9Q== X-Google-Smtp-Source: AGHT+IGYuVyhg41SQ3zbThKGfCB2EGcIg27COob6kv/mrCJSgl7qw3xHZu/RmDfFE6j57AumivXj3g== X-Received: by 2002:a17:902:9002:b0:1d0:6ffe:1e95 with SMTP id a2-20020a170902900200b001d06ffe1e95mr71192plp.120.1701463252698; Fri, 01 Dec 2023 12:40:52 -0800 (PST) Received: from free.home ([2804:7f1:2080:95b8:2c34:12ec:daf8:e1e5]) by smtp.gmail.com with ESMTPSA id v11-20020a1709028d8b00b001cc50146b43sm3756433plo.202.2023.12.01.12.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 12:40:52 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3B1KehNG105360 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 1 Dec 2023 17:40:44 -0300 From: Alexandre Oliva To: Jonathan Wakely , Jason Merrill Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH] libsupc++: try cxa_thread_atexit_impl at runtime Organization: Free thinker, does not speak for AdaCore References: Date: Fri, 01 Dec 2023 17:40:43 -0300 In-Reply-To: (Jonathan Wakely's message of "Thu, 9 Nov 2023 08:20:59 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 9, 2023, Jonathan Wakely wrote: > On Thu, 9 Nov 2023 at 01:56, Alexandre Oliva wrote: >> g++.dg/tls/thread_local-order2.C fails when the toolchain is built for >> a platform that lacks __cxa_thread_atexit_impl, even if the program is >> built and run using that toolchain on a (later) platform that offers >> __cxa_thread_atexit_impl. >> >> This patch adds runtime testing for __cxa_thread_atexit_impl on >> platforms that support weak symbols. >> >> Regstrapped on x86_64-linux-gnu, also tested with gcc-13 on i686- and >> x86_64-, and with ac_cv_func___cxa_thread_atexit_impl=no, that, on a >> distro that lacks __cxa_thread_atexit in libc, forces the newly-added >> code to be exercised, and that enabled thread_local-order2.C to pass >> where the runtime libc has __cxa_thread_atexit_impl. Ok to install? > Seems fine to me. Any objections, Jason? Jason, ping? https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635750.html -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive