From: Alexandre Oliva <oliva@adacore.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: require et random_device for cons token test
Date: Thu, 25 Mar 2021 07:17:27 -0300 [thread overview]
Message-ID: <ory2eb7d1k.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <20210324140140.GH3008@redhat.com> (Jonathan Wakely's message of "Wed, 24 Mar 2021 14:01:40 +0000")
On Mar 24, 2021, Jonathan Wakely <jwakely@redhat.com> wrote:
> This works for me on x86_64-linux and powerpc64le-linux, and also on
> x86_64-linux when I kluge the config macros so that the new code path
> gets used. Does this work for VxWorks?
Thanks. I (trivially) backported it to apply on our gcc-10 tree, and
tested that on x86_64-vx7r2, and I confirm it works there too.
However, I suspect there's a series of typos in the patch. You appear
to be using the 'which' enum variable for bit testing, but with '|'
rather than '&'.
Unless I'm missing something in my reading of the modified code, this
may cause a backend different from that requested by the token to be
selected, but it doesn't look like we have any test that detects this
problem.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
next prev parent reply other threads:[~2021-03-25 10:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 6:53 Alexandre Oliva
2021-03-24 8:59 ` Jonathan Wakely
2021-03-24 10:33 ` Alexandre Oliva
2021-03-24 11:27 ` Jonathan Wakely
2021-03-24 14:01 ` Jonathan Wakely
2021-03-25 10:17 ` Alexandre Oliva [this message]
2021-03-25 11:57 ` Jonathan Wakely
2021-03-26 19:17 ` Jonathan Wakely
2021-03-25 11:03 ` Alexandre Oliva
2021-03-25 11:39 ` Jonathan Wakely
2021-03-25 11:00 ` Alexandre Oliva
2021-03-25 11:38 ` Jonathan Wakely
2021-11-09 15:02 ` Jonathan Wakely
2021-03-24 10:55 ` Jonathan Wakely
2021-03-24 13:22 ` Koning, Paul
2021-03-24 13:38 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ory2eb7d1k.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).