From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 5E9D13858C52; Fri, 9 Sep 2022 18:36:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E9D13858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 0649EBCE44; Fri, 9 Sep 2022 20:36:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vxPxdXLmjaKn; Fri, 9 Sep 2022 20:36:26 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p5085519d.dip0.t-ipconnect.de [80.133.81.157]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 64E92BCD42; Fri, 9 Sep 2022 20:36:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1662748586; bh=T140ADjhjRq/1Ym1Xu+DFntAgHI+v99N6XAgNn34ge4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=b6xLZSuXUD9xDWnmXj5DriRnxlT2uD2dGb5mimUUJLmtie4u1EbYyiFnWJcItzUOS jme6nqJsnMgjT41XMoSVe0h6z1ng4ddBhWS4xkq8KV/DYihDz7/px/zCmGaxLn1Lus 6KUnpzQP4TT0QOcRj34L7hfpXSneVcac+MLcoXx2eIR9OqHpIhyMfUiX8O+xs5OTVW 5oIvL9ntaBUyOCo0xtBtGJG4glVkJe+Poyr50aUkEer8yqp88Jo/Y6CkHpnCVjY79K C3Xx6AnCOv5sXV6fIEGG+2sorA+5ACvvH0U4WkVyam7+XZO/ZiCZxBnaDXdcvGoht2 LSUhmtBEPZA/g== From: Rainer Orth To: Jonathan Wakely via Gcc-patches Cc: Thomas Rodgers , Jonathan Wakely , Jakub Jelinek , libstdc++ , Thomas Rodgers Subject: Re: Patch ping (was Re: [PATCH] libstdc++: Clear padding bits in atomic compare_exchange) References: <20210923180837.633173-1-rodgert@appliantology.com> <20210927141031.651313-1-rodgert@appliantology.com> Date: Fri, 09 Sep 2022 20:36:25 +0200 In-Reply-To: (Jonathan Wakely via Gcc-patches's message of "Wed, 7 Sep 2022 12:56:17 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3788.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jonathan, > Here's a complete patch that combines the various incremental patches > that have been going around. I'm testing this now. > > Please take a look. unfortunately, this patch broke macOS bootstrap (seen on x86_64-apple-darwin11.4.2): In file included from /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/bits/shared_ptr_atomic.h:33, from /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/memory:78, from /vol/gcc/src/hg/master/darwin/libstdc++-v3/include/precompiled/stdc++.h:82: /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/bits/atomic_base.h: In function 'bool std::__atomic_impl::__compare_exchange(_Tp&, _Val<_Tp>&, _Val<_Tp>&, bool, std::memory_order, std::memory_order)': /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/bits/atomic_base.h:1008:49: error: expected primary-expression before ',' token 1008 | __weak, int(__s), int(__f))) | ^ /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstdc++-v3/include/bits/atomic_base.h:1017:50: error: expected primary-expression before ',' token 1017 | __weak, int(__s), int(__f)); | ^ Darwin gcc predefines __weak= in gcc/config/darwin-c.cc (darwin_cpp_builtins). Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University