From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=4iIO=5N=cebitec.uni-bielefeld.de=ro@sourceware.org>
Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84])
	by sourceware.org (Postfix) with ESMTPS id 4BA183858D33;
	Mon, 16 Jan 2023 13:21:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BA183858D33
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de
Received: from localhost (localhost [127.0.0.1])
	by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 4A0E1110EA;
	Mon, 16 Jan 2023 14:21:36 +0100 (CET)
X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE
Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1])
	by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id NWjv1zhKm4FG; Mon, 16 Jan 2023 14:21:36 +0100 (CET)
Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508548b7.dip0.t-ipconnect.de [80.133.72.183])
	(Authenticated sender: ro)
	by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id D8DCD110E9;
	Mon, 16 Jan 2023 14:21:35 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
	d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1673875296;
	bh=Bxm9tG0O89ioFEHcI/jqi62mNjy3GyGf3L2Ij5Lk5Js=;
	h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
	b=fLIGzLxiSr3lP351+gg445kFLVKV0rihIiDDRc8kiPitd0G2gFgYcgHhMO91JW+HH
	 tsLHPf0z23CUFIxLp6wrBWSeLyDt1n6AQffFVTTNe/ifPpmkKrwZ8d6xB7+lJ7Q4Sg
	 +tvAKmnjzT1H6n4AOmxJ7O2RuOx+bdQtDN2uh0ygSK+P5YV54lgfcFHKKxn1qWlKr0
	 esCn/DYPItIBPRKN0hInIwY4e8Kj9+cUYVwYD7boZO7yLFMM9KRuj4JxdCPPVfhPdY
	 78t7PRxyd8tjC6+XpB4Vcpwwmg8r4Xa4oR6VWETqOKYUrejA1MF1iecOX8fSvzwzMq
	 ebmVf39ir0BhA==
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>,
  libstdc++@gcc.gnu.org
Subject: Re: [committed] libstdc++: Do not include <system_error> in
 concurrency headers
References: <20230113001546.944147-1-jwakely@redhat.com>
	<yddy1q6a2vk.fsf@CeBiTec.Uni-Bielefeld.DE>
	<CACb0b4nZdOEUugsbXNEg_b==h3xaK_wB=zoaMGEAN7JQtKrvKA@mail.gmail.com>
	<CACb0b4ncLt4oc_D6v_tY+qoWPjjMCGMDLzNC5EyyynqA1uxT4w@mail.gmail.com>
Date: Mon, 16 Jan 2023 14:21:35 +0100
In-Reply-To: <CACb0b4ncLt4oc_D6v_tY+qoWPjjMCGMDLzNC5EyyynqA1uxT4w@mail.gmail.com>
	(Jonathan Wakely's message of "Fri, 13 Jan 2023 17:38:20 +0000")
Message-ID: <yddcz7eaa3k.fsf@CeBiTec.Uni-Bielefeld.DE>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3788.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libstdc++.gcc.gnu.org>

Hi Jonathan,

> On Fri, 13 Jan 2023 at 16:39, Jonathan Wakely wrote:
>>
>> On Fri, 13 Jan 2023 at 15:08, Rainer Orth wrote:
>> >
>> > Hi Jonathan,
>> >
>> > > The <condition_variable>, <mutex>, and <shared_mutex> headers use
>> > > std::errc constants, but don't use std::system_error itself. They only
>> > > use the __throw_system_error(int) function, which is defined in
>> > > <bits/functexcept.h>.
>> > >
>> > > By including the header for the errc constants instead of the whole of
>> > > <system_error> we avoid depending on the whole std::string definition.
>> >
>> > it seems this patch broke many tests on Solaris, e.g.
>> >
>> > FAIL: 29_atomics/atomic/requirements/types_neg.cc (test for excess errors)
>> > Excess errors:
>> > /var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/libstdc++-v3/include/bits/std_mutex.h:157:
>> > error: 'EBUSY' was not declared in this scope
>> >
>>
>> Oops, testing this patch now.
>
> Pushed to trunk - thanks for the report!

great, thanks for the quick fix.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University