From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 406DA385414E; Fri, 24 Jun 2022 11:41:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 406DA385414E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 1E9A0BD9D9; Fri, 24 Jun 2022 13:41:16 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ODegglEmZdHP; Fri, 24 Jun 2022 13:41:15 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508554ce.dip0.t-ipconnect.de [80.133.84.206]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id B64A5BDBB5; Fri, 24 Jun 2022 13:41:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1656070875; bh=t59qjuNr7L5os1O7t1w96Un9seEVVvm3xp0PFvpuRc8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=k4new5QxRJlixuQ/oaF4n69xgGzoPpNPOBAB3CeVizC8Cw3IYFie0s7XQIVomYlIH ErY9M71uuTGXAFf36xZAfIA/LqVA3M6P/myBMPcZwiZhlOQwKWArYEYIYLHUb4YBoN Od0LXHlRkP1MvcP3sDbmGJGe+3FkJCOzh6VcL/Qjdlc4BBdyoG39Ql0TWAZ82qvm5y rIE/abzUDNkC1W+gNy96J+bfxw0enQXuXGe6TE7GAA7oc3hi/wIOg+yof5Vg/Nf5cc KN0BN0F4sz3Uv0xhjv1pMz6ajEd47u3zeE2hYcsQdz9qukBxsLlSWODyjbGd9fhTce 6Uo1HgydTK2rQ== From: Rainer Orth To: Jonathan Wakely Cc: Xi Ruoyao , Jonathan Wakely , "libstdc++" , gcc-patches Subject: Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts References: <74ea0c62ebe19db186263053e4051f81d46e9da4.camel@xry111.site> Date: Fri, 24 Jun 2022 13:41:15 +0200 In-Reply-To: (Jonathan Wakely's message of "Fri, 24 Jun 2022 12:35:22 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3788.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 11:41:18 -0000 Hi Jonathan, >> > I'll need some rework as Rainer told me "grep -E" may not work on some >> > Solaris systems w/o GNU grep, and the code snippet in extract_symvers.in >> > is exactly for Solaris... >> >> I checked that, and it's not :-) >> >> The egrep uses in extract_symvers.in are for everything *except* >> SunOS. For Solaris we use the scripts/extract_symvers.pl script >> instead. >> >> Your change might break generation of Doxygen API docs on Solaris, but >> maybe we can live with that. > > /usr/xpg4/bin/grep supports the -E flag, so I was going to say that > it's acceptable to require that version in the PATH when generating > the API docs with doxygen. But in fact that script already assumes GNU indeed: for a niche/developer-only use, the bar of tool requirements can be higher IMO. Besides, /usr/gnu/bin/grep is there, too (or could be; both /usr/xpg4/bin/grep and /usr/gnu/bin/grep live in separate packages that may or may not be installed). I just want to make the entry barries for normal builds as low as possible. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University