From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id AB9E63951413 for ; Wed, 21 Jul 2021 13:04:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AB9E63951413 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id BA1649557; Wed, 21 Jul 2021 15:04:56 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2LcPr_aMabPT; Wed, 21 Jul 2021 15:04:56 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50854661.dip0.t-ipconnect.de [80.133.70.97]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 34CB3EAB9; Wed, 21 Jul 2021 15:04:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1626872696; bh=ngfxh+pBAjI5Tpuq6eRKirRfTjJzNI7c6fag8UPjjTQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fcp0jA2JwxpKxHgYE0R8HaIKc/koAJAYhFTBRGIiMKZTuPTMmNY2yym+yfIz6Pvc1 3BJj5Si+c43uiYFX9ALsD4FqH/6mu41ccvhCbdT2QFSOXgBtoZw1Ymgr38vnjnGAvC 3HuhfHXDEV78G3A9NUn/Gwk/ZTauPnqgffdHS6BwR9oAFXQ72uTCV2oOSFrx1F9cK2 Ezk03pDJUeYvODRJKAneETUYWUN/kInhkD7Ospp3mpnTqsMY09HPGOx1yXSZh1dqhX vE8gP277aZ6l4OqEvFpbpN3gisd3S8HbgNzPYo5xrt8N/LvcrCgKjQPBOq1IXLly5N zn/LhmqrjufSQ== From: Rainer Orth To: "CHIGOT, CLEMENT" Cc: libstdc++ , Jonathan Wakely , David Edelsohn Subject: Re: [PATCH] libstdc++: implement locale support for AIX References: <20210122112910.GI541588@redhat.com> Date: Wed, 21 Jul 2021 15:04:55 +0200 In-Reply-To: (CLEMENT CHIGOT's message of "Wed, 21 Jul 2021 12:00:35 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3786.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2021 13:05:01 -0000 Hi Clement, > Here is a new version of the patch with the Solaris part > made by Rainer directly integrated in it. fine, thanks. > Rainer did you change anything in the configure file or > did you just pass XPG7 model with the configure option ? When I last tested it, I just configured with --enable-clocale=xpg7. > I guess if it works fine on Solaris target, it can be > directly chosen inside the configure. Agreed, however right now we're not even close for that. > A part from that it would be good if someone familiar with > freebsd or dragonfly can take a look at it. There shouldn't be > any problems but it needs to be tested and a few #ifdef remain > for these two targets. I'd tried DragonflyBSD quite some time ago, but couldn't even get it to boot in VirtualBox and didn't want to spend too much time on it. However, the last i586-unknown-freebsd11.4 test results for unmodified trunk are still terrible, showing 101 FAILs in libstdc++, a large number among those being locale tests. I had seen (not unexpectedly) similarly abysmal results when I tried an earlier version of your patch on (I believe) FreeBSD 12 in VirtualBox some time ago, which made me question if that clocale implementation is a good basis for xpg7 if it doesn't even work on the target it's supposed to support. Could you please share the libstdc++-v3 mail-report.log snippet you get on AIX with your latest patch as a point of comparison? Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University