From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 57D47386EC6E; Wed, 27 Jan 2021 14:26:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 57D47386EC6E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id E562566C36; Wed, 27 Jan 2021 15:26:06 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mKqWHPeR_NpF; Wed, 27 Jan 2021 15:26:06 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50855c8f.dip0.t-ipconnect.de [80.133.92.143]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 2177466A63; Wed, 27 Jan 2021 15:26:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1611757566; bh=TRmTE6GLlIpw9hf0+5pNVJKmIGYh0JDHyf2CLcQXbfc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FpZJP1+BmUGEGu8dmeJs/uZqOPVil1vIXjflH3yiUUAw98kftdb+jT+K4vva0vj5w VRjjwbPbepTHygMhsWDyKCpNmTmx9vnQrPJnpfU0IrqSmthj0JBiuBUXB/1wUcGPmG MHqF8HRpsalM6811tZgbvxNRq70oiiU7yK7nypxN8l2xLskOMQY/DuCVBQKvvdZ2gF 58kK2J9atgkGrfu62OvzJsizFNnFc/CesrHgN/4Roa6SYEgf9NytWoCk4l2bAZPKqW fN57c4SoucUd7q0hEMqpv2Cd7RhxeUnCiAzkLBMnEJLkNvv6QxeL6rlO/R1Xjn0PrH 7yf8gmD3eqi/Q== From: Rainer Orth To: "CHIGOT, CLEMENT" Cc: Jonathan Wakely , libstdc++ , David Edelsohn via Gcc-patches , David Edelsohn Subject: Re: [PATCH] libstdc++: implement locale support for AIX References: <20210122112910.GI541588@redhat.com> Date: Wed, 27 Jan 2021 15:26:05 +0100 In-Reply-To: (CLEMENT CHIGOT's message of "Wed, 27 Jan 2021 12:52:21 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3789.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2021 14:26:12 -0000 Hi Clement, > Here is a better version of the patch.=C2=A0 > All tests are on Linux are passing. Few have been disabled as=C2=A0 > they are working only with GNU model.=C2=A0 > For AIX, few failures remains. I haven't XFAIL them yet, as I=C2=A0 > want to know if they AIX only or related to the model itself.=C2=A0 > > A few part still need to be improved (dg-require-localmodel, > std::locale:global, FreeBSD specific #ifdef).=C2=A0 > But at least it can be=C2=A0tested in most of the=C2=A0platforms as is.= =C2=A0 > > Note that I'll stop working on it until gcc12. Mostly because gcc > is on freeze but also because I've more urgent stuff to do right now.=C2= =A0 > Of course any feedbacks is welcome ! But I might not send a > new patch if it requires too much time (at least not right now).=C2=A0 > > Thanks anyway Rainer and Jonathan for your help ! I hope this=C2=A0 > version suits you better ! very much so, thanks a lot for your work! I've just looked over it to determine what changes to config/os/solaris are necessary and found a few nits: * There are minor formatting issues: Should the linebreak in the extern inline definitions of strtof_l be after the return type, not before, matching GNU coding standards? It may well be that the C++ style is different, though. Unrelated whitespace changes in xpg7/ctype_members.cc * The changes in the copyright ranges need to be undone, given that this is just a renamed/augmented version of the previous dragonfly code. * Seeing the __DragonFly__ || __FreeBSD__ again, I had a quick look at the FreeBSD 12.2 headers and found that localeconv_l does take a locale_t arg, just like uselocale. DragonFlyBSD seems to be the same according to their online manuals. I expect to give the code a try in a FreeBSD 12.2 VM at some point to check. * While you now define _GLIBCXX_C_LOCALE_XPG7 in config/locale/xpg7/c_locale.h, config/os/aix/ctype_configure_char.cc still tests the previous _GLIBCXX_C_LOCALE_IEEE_2008. Nothing tested yet, just wanted to point those out ASAP. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University