From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id A44A4386102D; Mon, 11 Jan 2021 15:38:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A44A4386102D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 877EFA8C98; Mon, 11 Jan 2021 16:38:29 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A9EWYuZElIcH; Mon, 11 Jan 2021 16:38:29 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddbad1.dip0.t-ipconnect.de [79.221.186.209]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 0BE43A8842; Mon, 11 Jan 2021 16:38:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1610379509; bh=7IzCQkrNK5s/GT/UOyH1qi03+roOdooXtylW8y7ei0s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=d7l51x40RUJAUWU1I9LXMl8BWFBb9Qam0Zr8tNqH5Y5OCmm4QrvvfRO2tjZeWH8bp VJqMzvwijyvnSv06+JLAZ9UhwAwqjZvSHf33htQoqpYwb7qjlEgra1xTDE+23Ey2o0 Ai9uVbL2bMo2Sx6pKKWZ0Byl7Ip0QFwJK8t5d3sVRZT1b/GKzG9k9p/LLLrs6uuZX+ KtELNRQBddW3WrPAn8GC+MDzVy1blq3JnU+zz15DukmXLCgDFtf0p6GsqLBPpYXcqK WBY9z2s1bjVDYcFGqZQJmCMIGiTBDgWg36EvC6glGdQz2njnNtsiQBDJF3wUy/f/jv NLEiXRsmtwqoA== From: Rainer Orth To: "CHIGOT, CLEMENT via Gcc-patches" Cc: David Edelsohn , "CHIGOT, CLEMENT" , libstdc++@gcc.gnu.org, Jonathan Wakely Subject: Re: [PATCH] libstdc++: implement locale support for AIX References: Date: Mon, 11 Jan 2021 16:38:28 +0100 In-Reply-To: (CLEMENT via Gcc-patches CHIGOT's message of "Mon, 11 Jan 2021 15:22:55 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3789.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 15:38:31 -0000 Hi Clement, > Would "Skip if target = aix" be ok, especially for the few that I have > absolutely no idea why they are failing ? you should try to avoid such skips if at all possible. Should the tests start to PASS in the future, either due to AIX changes or changes in libstdc++, this would go unnoticed. Use xfail instead. Besides, you should file PRs for the failing tests and preferably mention the relevant PR in the xfail. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University