From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ZkKe=5K=cebitec.uni-bielefeld.de=ro@sourceware.org>
Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84])
	by sourceware.org (Postfix) with ESMTPS id 1AC483858D37;
	Fri, 13 Jan 2023 15:08:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AC483858D37
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de
Received: from localhost (localhost [127.0.0.1])
	by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 572EDC276B;
	Fri, 13 Jan 2023 16:08:33 +0100 (CET)
X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE
Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1])
	by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id oqeL7ZOtG-mu; Fri, 13 Jan 2023 16:08:32 +0100 (CET)
Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508548b7.dip0.t-ipconnect.de [80.133.72.183])
	(Authenticated sender: ro)
	by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 8D41CC2D92;
	Fri, 13 Jan 2023 16:08:32 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
	d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1673622512;
	bh=eseZAGJWaWpjvvkR6ovZYfFbpy+aS6/wQ4QxU7KkhUU=;
	h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
	b=HQAWCgECfmcwXKmBuz1Dv40jvFdTfE1nw+q0U8wXo0hsnW8IEZe7qXFq7LwkMzF86
	 u518O0DdAmRw4N9yxBOOGhxc1BeEgnDRf2rIyr+ssZ8fsQQlKatvSZgmpMSCwj6tta
	 wQoE053pjLnEIhOPwxXLEuLbGw/owWRik5yZM1jkp79dycRGx2xAvN/SRBEfHvUhia
	 aTtLja6zvUKnoKj8NUFjNy9VctUdN6xe0BeF81fGjJe+KQZpBaOIR/nXtIlC009Nhg
	 am4p0Bi+3pUVkGxoRweSxG6XgI1+2Vu5tQsry29k7Cs+hoSoOZhEukDUlZlQV1Wo0w
	 725DbE3t88xmg==
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: libstdc++@gcc.gnu.org,  Jonathan Wakely <jwakely@redhat.com>
Subject: Re: [committed] libstdc++: Do not include <system_error> in
 concurrency headers
References: <20230113001546.944147-1-jwakely@redhat.com>
Date: Fri, 13 Jan 2023 16:08:31 +0100
In-Reply-To: <20230113001546.944147-1-jwakely@redhat.com> (Jonathan Wakely via
	Gcc-patches's message of "Fri, 13 Jan 2023 00:15:46 +0000")
Message-ID: <yddy1q6a2vk.fsf@CeBiTec.Uni-Bielefeld.DE>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3788.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libstdc++.gcc.gnu.org>

Hi Jonathan,

> The <condition_variable>, <mutex>, and <shared_mutex> headers use
> std::errc constants, but don't use std::system_error itself. They only
> use the __throw_system_error(int) function, which is defined in
> <bits/functexcept.h>.
>
> By including the header for the errc constants instead of the whole of
> <system_error> we avoid depending on the whole std::string definition.

it seems this patch broke many tests on Solaris, e.g.

FAIL: 29_atomics/atomic/requirements/types_neg.cc (test for excess errors)
Excess errors:
/var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/libstdc++-v3/include/bits/std_mutex.h:157: error: 'EBUSY' was not declared in this scope

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University