public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/metadata.c Date: Tue, 04 Jul 2006 19:36:00 -0000 [thread overview] Message-ID: <20060704193649.27103.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2006-07-04 19:36:49 Modified files: . : WHATS_NEW lib/metadata : metadata.c Log message: Add some forgotten memlock checks to _vg_read to protect against full scans. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.405&r2=1.406 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.93&r2=1.94 --- LVM2/WHATS_NEW 2006/07/04 18:57:26 1.405 +++ LVM2/WHATS_NEW 2006/07/04 19:36:48 1.406 @@ -1,5 +1,6 @@ Version 2.02.07 - ================================= + Add some forgotten memlock checks to _vg_read to protect against full scans. Add mutex to dmeventd_mirror to avoid concurrent execution. Fix vgreduce --removemissing to return success if VG is already consistent. Fix return code if VG specified on command line is not found. --- LVM2/lib/metadata/metadata.c 2006/05/11 17:58:58 1.93 +++ LVM2/lib/metadata/metadata.c 2006/07/04 19:36:49 1.94 @@ -993,7 +993,11 @@ if (list_size(&correct_vg->pvs) != list_size(pvids)) { log_debug("Cached VG %s had incorrect PV list", vg->name); - correct_vg = NULL; + + if (memlock()) + inconsistent = 1; + else + correct_vg = NULL; } else list_iterate_items(pvl, &correct_vg->pvs) { if (!str_list_match_item(pvids, pvl->pv->dev->pvid)) { log_debug("Cached VG %s had incorrect PV list", @@ -1008,6 +1012,10 @@ if (!correct_vg) { inconsistent = 0; + if (memlock()) { + stack; + return NULL; + } lvmcache_label_scan(cmd, 2); if (!(fmt = fmt_from_vgname(vgname, vgid))) { stack; @@ -1149,7 +1157,8 @@ if (!consistent) { log_error("Volume group %s metadata is " "inconsistent", vginfo->vgname); - return NULL; + if (!partial_mode()) + return NULL; } return vg; }
next reply other threads:[~2006-07-04 19:36 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2006-07-04 19:36 agk [this message] 2006-08-09 19:33 agk 2006-09-21 20:25 agk 2007-07-02 21:48 wysochanski 2007-10-12 18:37 wysochanski 2008-04-04 15:41 wysochanski 2008-04-07 22:12 agk 2008-05-08 18:06 agk 2008-06-03 17:56 agk 2008-09-25 15:59 mbroz 2009-01-26 22:43 agk 2009-04-10 9:56 mbroz 2009-04-22 9:31 mbroz 2009-05-12 19:09 mbroz 2009-05-27 13:19 agk 2009-07-16 3:25 wysochanski 2009-08-20 7:03 mbroz 2009-12-09 19:29 mbroz 2009-12-11 13:14 zkabelac 2009-12-18 12:44 mbroz 2009-12-18 12:45 mbroz 2010-01-05 16:01 mbroz 2010-01-21 21:09 wysochanski 2010-03-02 21:56 snitzer 2010-04-01 11:43 agk 2010-05-21 12:45 zkabelac 2010-06-22 21:10 mbroz 2010-08-19 23:03 mbroz 2010-11-29 11:08 zkabelac 2010-12-08 10:45 zkabelac 2011-03-10 13:12 zkabelac 2011-03-11 15:06 prajnoha 2011-03-29 21:57 zkabelac 2011-08-04 15:18 zkabelac 2011-08-11 16:31 prajnoha 2011-10-24 10:24 zkabelac 2011-11-18 19:28 zkabelac 2012-02-13 10:51 zkabelac 2012-02-13 10:58 zkabelac 2012-02-13 11:01 zkabelac 2012-02-23 0:11 agk 2012-03-12 14:18 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20060704193649.27103.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).