From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 778 invoked by alias); 19 Sep 2006 19:13:42 -0000 Received: (qmail 765 invoked by uid 9447); 19 Sep 2006 19:13:42 -0000 Date: Tue, 19 Sep 2006 19:13:00 -0000 Message-ID: <20060919191342.763.qmail@sourceware.org> From: agk@sourceware.org To: lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/mirror.c tools/l ... Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00004.txt.bz2 List-Id: CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2006-09-19 19:13:41 Modified files: . : WHATS_NEW lib/metadata : mirror.c tools : lvconvert.c Log message: Fix lvconvert mirror change case detection logic. Fix mirror log detachment so it correctly becomes a standalone LV. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.438&r2=1.439 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.32&r2=1.33 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.20&r2=1.21 --- LVM2/WHATS_NEW 2006/09/11 21:14:55 1.438 +++ LVM2/WHATS_NEW 2006/09/19 19:13:41 1.439 @@ -1,5 +1,7 @@ Version 2.02.10 - ================================== + Fix lvconvert mirror change case detection logic. + Fix mirror log detachment so it correctly becomes a standalone LV. Extend _check_contiguous() to detect single-area LVs. Include mirror log (untested) in _for_each_pv() processing. Use MIRROR_LOG_SIZE constant. --- LVM2/lib/metadata/mirror.c 2006/08/21 12:54:53 1.32 +++ LVM2/lib/metadata/mirror.c 2006/09/19 19:13:41 1.33 @@ -161,9 +161,11 @@ remove_log = 1; } - if (remove_log) { + if (remove_log && mirrored_seg->log_lv) { log_lv = mirrored_seg->log_lv; mirrored_seg->log_lv = NULL; + log_lv->status &= ~MIRROR_LOG; + log_lv->status |= VISIBLE_LV; } /* --- LVM2/tools/lvconvert.c 2006/09/02 01:18:17 1.20 +++ LVM2/tools/lvconvert.c 2006/09/19 19:13:41 1.21 @@ -344,8 +344,7 @@ lp->mirrors - 1); return 1; } - } - if (lp->mirrors > existing_mirrors) { + } else if (lp->mirrors > existing_mirrors) { /* FIXME Unless anywhere, remove PV of log_lv * from allocatable_pvs & allocate * (mirrors - existing_mirrors) new areas