public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW scripts/lvm2_monitoring_init_ ... Date: Tue, 30 Jan 2007 18:02:00 -0000 [thread overview] Message-ID: <20070130180216.25040.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2007-01-30 18:02:15 Modified files: . : WHATS_NEW scripts : lvm2_monitoring_init_rhel4 Log message: Add warning to lvm2_monitoring_init_rhel4 if attempting to stop monitoring. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.565&r2=1.566 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/scripts/lvm2_monitoring_init_rhel4.diff?cvsroot=lvm2&r1=1.1&r2=1.2 --- LVM2/WHATS_NEW 2007/01/29 23:01:17 1.565 +++ LVM2/WHATS_NEW 2007/01/30 18:02:15 1.566 @@ -1,5 +1,6 @@ Version 2.02.21 - =================================== + Add warning to lvm2_monitoring_init_rhel4 if attempting to stop monitoring. Fix vgsplit to handle mirrors. Reorder fields in reporting field definitions. Fix vgs to treat args as VGs even when PV fields are displayed. --- LVM2/scripts/lvm2_monitoring_init_rhel4 2007/01/24 23:43:27 1.1 +++ LVM2/scripts/lvm2_monitoring_init_rhel4 2007/01/30 18:02:15 1.2 @@ -25,11 +25,11 @@ . /etc/init.d/functions VGCHANGE="/usr/sbin/vgchange" +WARN=1 start() { - for ret in 0 - do + ret=0 # TODO do we want to separate out already active groups only? VGS=`vgs --noheadings -o name` for vg in $VGS @@ -40,50 +40,58 @@ fi done - done - - return $ret + return $ret } stop() { - for ret in 0 - do + ret=0 # TODO do we want to separate out already active groups only? + if test "$WARN" = "1"; then + echo "Not stopping monitoring, this is a dangerous operation. Please use force-stop to override." + return 1 + fi VGS=`vgs --noheadings -o name` for vg in $VGS do - if ! action "Starting monitoring for VG $vg:" $VGCHANGE --monitor n $vg + if ! action "Stopping monitoring for VG $vg:" $VGCHANGE --monitor n $vg then ret=$? fi done - - done - + return $ret } -ret=1 +result=1 # See how we were called. case "$1" in start) start - ret=$? + result=$? + ;; + + force-stop) + WARN=0 + stop + result=$? ;; stop) + test "$runlevel" = "0" && WARN=0 + test "$runlevel" = "6" && WARN=0 stop - ret=$? + result=$? ;; restart) + WARN=0 if stop then start fi - ret=$? + result=$? ;; status) @@ -91,8 +99,8 @@ ;; *) - echo $"Usage: $0 {start|stop|restart|status}" + echo $"Usage: $0 {start|stop|restart|status|force-stop}" ;; esac -exit $ret +exit $result
next reply other threads:[~2007-01-30 18:02 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-01-30 18:02 agk [this message] 2010-04-15 19:15 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070130180216.25040.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).