public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/commands/toolcontext.c Date: Thu, 08 Feb 2007 17:31:00 -0000 [thread overview] Message-ID: <20070208173103.26558.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2007-02-08 17:31:03 Modified files: . : WHATS_NEW lib/commands : toolcontext.c Log message: Fix loading of segment_libraries. [gentoo] Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.570&r2=1.571 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.47&r2=1.48 --- LVM2/WHATS_NEW 2007/02/07 13:29:51 1.570 +++ LVM2/WHATS_NEW 2007/02/08 17:31:02 1.571 @@ -1,5 +1,6 @@ Version 2.02.22 - =================================== + Fix loading of segment_libraries. If a PV reappears after it was removed from its VG, make it an orphan. Don't update metadata automatically if VGIDs don't match. Fix some vgreduce --removemissing command line validation. --- LVM2/lib/commands/toolcontext.c 2007/01/25 21:22:30 1.47 +++ LVM2/lib/commands/toolcontext.c 2007/02/08 17:31:02 1.48 @@ -754,7 +754,6 @@ struct config_value *cv; struct segment_type *(*init_segtype_fn) (struct cmd_context *); void *lib; - struct list *sgtl, *tmp; struct segment_type *segtype2; for (cv = cn->v; cv; cv = cv->next) { @@ -781,18 +780,16 @@ segtype->library = lib; list_add(&cmd->segtypes, &segtype->list); - list_iterate_safe(sgtl, tmp, &cmd->segtypes) { - segtype2 = list_item(sgtl, struct segment_type); - if (!strcmp(segtype2->name, segtype->name)) { - log_error("Duplicate segment type %s: " - "unloading shared library %s", - segtype->name, cv->v.str); - list_del(&segtype->list); - segtype->ops->destroy(segtype); - dlclose(lib); - break; - } - + list_iterate_items(segtype2, &cmd->segtypes) { + if ((segtype == segtype2) || + strcmp(segtype2->name, segtype->name)) + continue; + log_error("Duplicate segment type %s: " + "unloading shared library %s", + segtype->name, cv->v.str); + list_del(&segtype->list); + segtype->ops->destroy(segtype); + dlclose(lib); } } }
next reply other threads:[~2007-02-08 17:31 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-08 17:31 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-23 13:02 zkabelac 2012-03-23 9:42 zkabelac 2012-02-27 10:05 zkabelac 2012-02-08 10:46 zkabelac 2011-07-08 16:49 agk 2011-06-28 0:23 agk 2010-11-24 9:34 zkabelac 2010-04-30 12:37 zkabelac 2009-07-21 20:00 mpatocka 2009-07-14 12:17 mbroz 2009-06-15 11:56 mbroz 2009-04-02 20:46 taka 2007-01-23 16:03 agk 2005-01-27 15:50 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070208173103.26558.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).