public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/activate/dev_manager.c Date: Thu, 08 Mar 2007 19:58:00 -0000 [thread overview] Message-ID: <20070308195805.9948.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2007-03-08 19:58:04 Modified files: . : WHATS_NEW lib/activate : dev_manager.c Log message: Remove no-longer-used uuid_out parameter from activation info functions. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.578&r2=1.579 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/dev_manager.c.diff?cvsroot=lvm2&r1=1.120&r2=1.121 --- LVM2/WHATS_NEW 2007/03/08 19:22:52 1.578 +++ LVM2/WHATS_NEW 2007/03/08 19:58:04 1.579 @@ -1,5 +1,6 @@ Version 2.02.23 - ==================================== + Remove no-longer-used uuid_out parameter from activation info functions. Fix two more segfaults if an empty config file section encountered. Move .cache file into a new /etc/lvm/cache directory by default. Add devices/cache_dir & devices/cache_file_prefix, deprecating devices/cache. --- LVM2/lib/activate/dev_manager.c 2007/01/25 23:03:47 1.120 +++ LVM2/lib/activate/dev_manager.c 2007/03/08 19:58:04 1.121 @@ -118,12 +118,10 @@ } static int _info_run(const char *name, const char *dlid, struct dm_info *info, - int mknodes, int with_open_count, struct dm_pool *mem, - char **uuid_out) + int mknodes, int with_open_count) { int r = 0; struct dm_task *dmt; - const char *u; int dmtask; dmtask = mknodes ? DM_DEVICE_MKNODES : DM_DEVICE_INFO; @@ -143,11 +141,6 @@ if (!dm_task_get_info(dmt, info)) goto_out; - if (info->exists && uuid_out) { - if (!(u = dm_task_get_uuid(dmt))) - goto_out; - *uuid_out = dm_pool_strdup(mem, u); - } r = 1; out: @@ -208,23 +201,20 @@ } static int _info(const char *name, const char *dlid, int mknodes, - int with_open_count, struct dm_info *info, - struct dm_pool *mem, char **uuid_out) + int with_open_count, struct dm_info *info) { if (!mknodes && dlid && *dlid) { - if (_info_run(NULL, dlid, info, 0, with_open_count, mem, - uuid_out) && + if (_info_run(NULL, dlid, info, 0, with_open_count) && info->exists) return 1; else if (_info_run(NULL, dlid + sizeof(UUID_PREFIX) - 1, info, - 0, with_open_count, mem, uuid_out) && + 0, with_open_count) && info->exists) return 1; } if (name) - return _info_run(name, NULL, info, mknodes, with_open_count, - mem, uuid_out); + return _info_run(name, NULL, info, mknodes, with_open_count); return 0; } @@ -240,8 +230,7 @@ return 0; } - return _info(name, dlid, with_mknodes, with_open_count, info, - NULL, NULL); + return _info(name, dlid, with_mknodes, with_open_count, info); } /* FIXME Interface must cope with multiple targets */ @@ -646,7 +635,7 @@ return_0; log_debug("Getting device info for %s [%s]", name, dlid); - if (!_info(name, dlid, 0, 1, &info, dm->mem, NULL)) { + if (!_info(name, dlid, 0, 1, &info)) { log_error("Failed to get info for %s [%s].", name, dlid); return 0; }
next reply other threads:[~2007-03-08 19:58 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-03-08 19:58 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-16 12:50 agk 2012-04-20 14:17 jbrassow 2012-03-05 14:15 zkabelac 2012-02-01 13:47 zkabelac 2012-01-28 20:12 zkabelac 2012-01-23 20:56 jbrassow 2012-01-20 21:56 snitzer 2011-12-21 12:59 zkabelac 2011-11-18 19:42 zkabelac 2011-10-11 8:59 zkabelac 2011-10-11 8:57 zkabelac 2011-08-11 4:18 jbrassow 2011-07-06 0:29 agk 2011-07-05 23:10 agk 2011-01-05 14:03 zkabelac 2010-12-08 19:26 agk 2010-10-25 10:37 agk 2010-10-24 17:37 snitzer 2010-08-26 14:21 jbrassow 2010-08-17 1:51 agk 2010-08-03 13:13 zkabelac 2010-05-24 9:01 zkabelac 2010-05-21 14:48 zkabelac 2010-02-08 23:28 snitzer 2010-01-26 7:58 mbroz 2010-01-22 15:40 snitzer 2009-08-03 18:09 agk 2009-05-28 1:11 agk 2009-05-13 14:13 zkabelac 2008-12-19 15:23 mbroz 2008-06-05 12:45 agk 2007-05-14 11:27 mbroz 2006-11-20 16:45 agk 2006-07-10 19:17 agk 2005-10-18 12:39 agk 2005-08-04 1:27 agk 2005-08-04 1:15 agk 2004-05-12 20:43 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070308195805.9948.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).