From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7247 invoked by alias); 15 May 2007 13:01:44 -0000 Received: (qmail 7229 invoked by uid 9664); 15 May 2007 13:01:42 -0000 Date: Tue, 15 May 2007 13:01:00 -0000 Message-ID: <20070515130142.7227.qmail@sourceware.org> From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/vgsplit.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00003.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2007-05-15 13:01:41 Modified files: . : WHATS_NEW tools : vgsplit.c Log message: Fix and clarify vgsplit error messages. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.616&r2=1.617 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgsplit.c.diff?cvsroot=lvm2&r1=1.24&r2=1.25 --- LVM2/WHATS_NEW 2007/05/14 11:27:33 1.616 +++ LVM2/WHATS_NEW 2007/05/15 13:01:40 1.617 @@ -1,5 +1,6 @@ Version 2.02.26 - ================================= + Fix and clarify vgsplit error messages. Fix a segfault if a device has no target (no table) Add some more debuglogs to clvmd startup. Misc clvmd cleanups --- LVM2/tools/vgsplit.c 2007/03/23 12:43:17 1.24 +++ LVM2/tools/vgsplit.c 2007/05/15 13:01:41 1.25 @@ -145,13 +145,16 @@ list_iterate_items(seg, &lv->segments) { cow_from = _lv_is_in_vg(vg_from, seg->cow); origin_from = _lv_is_in_vg(vg_from, seg->origin); + + if (cow_from && origin_from) + continue; + if ((!cow_from && origin_from) || + (cow_from && !origin_from)) { + log_error("Can't split snapshot %s between" + " two Volume Groups", seg->cow->name); + return 0; + } } - if (cow_from && origin_from) - continue; - if ((!cow_from && origin_from) || (cow_from && !origin_from)) { - log_error("Snapshot %s split", seg->cow->name); - return 0; - } /* Move this snapshot */ list_del(lvh); @@ -190,7 +193,8 @@ if ((seg_in && seg_in < seg->area_count) || (seg_in && seg->log_lv && !log_in) || (!seg_in && seg->log_lv && log_in)) { - log_error("Mirror %s split", lv->name); + log_error("Can't split mirror %s between " + "two Volume Groups", lv->name); return 0; }