public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvcreate.c Date: Tue, 17 Jul 2007 16:13:00 -0000 [thread overview] Message-ID: <20070717161313.24537.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2007-07-17 16:13:12 Modified files: . : WHATS_NEW tools : lvcreate.c Log message: Fix snapshot cow area deactivation if origin is not active. (2.02.13) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.656&r2=1.657 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.137&r2=1.138 --- LVM2/WHATS_NEW 2007/07/13 17:08:00 1.656 +++ LVM2/WHATS_NEW 2007/07/17 16:13:12 1.657 @@ -1,5 +1,6 @@ Version 2.02.27 - ================================ + Fix snapshot cow area deactivation if origin is not active. (2.02.13) Fix configure libdevmapper.h check when --with-dmdir is used. Turn _add_pv_to_vg() into external library function add_pv_to_vg(). Add pv_by_path() external library function. --- LVM2/tools/lvcreate.c 2007/06/28 17:33:44 1.137 +++ LVM2/tools/lvcreate.c 2007/07/17 16:13:12 1.138 @@ -478,10 +478,11 @@ struct logical_volume *lv, *org = NULL, *log_lv = NULL; struct list *pvh, tags; const char *tag = NULL; - int consistent = 1; + int consistent = 1, origin_active = 0; struct alloc_handle *ah = NULL; char lv_name_buf[128]; const char *lv_name; + struct lvinfo info; status |= lp->permission | VISIBLE_LV; @@ -615,6 +616,13 @@ /* Must zero cow */ status |= LVM_WRITE; + + if (!lv_info(cmd, org, &info, 0)) { + log_error("Check for existence of snapshot origin " + "'%s' failed.", org->name); + return 0; + } + origin_active = info.exists; } if (!lp->extents) { @@ -792,6 +800,13 @@ if (!(lp->permission & LVM_WRITE)) lv->status &= ~LVM_WRITE; + /* COW area must be deactivated if origin is not active */ + if (!origin_active && !deactivate_lv(cmd, lv)) { + log_error("Aborting. Couldn't deactivate snapshot " + "COW area."); + return 0; + } + /* cow LV remains active and becomes snapshot LV */ if (!vg_add_snapshot(vg->fid, NULL, org, lv, NULL,
next reply other threads:[~2007-07-17 16:13 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-07-17 16:13 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-11 12:33 zkabelac 2012-03-02 17:25 zkabelac 2012-03-01 21:21 zkabelac 2012-02-27 10:00 zkabelac 2011-11-07 11:01 zkabelac 2011-09-22 15:36 jbrassow 2008-09-24 16:32 mbroz 2008-06-05 13:38 agk 2008-01-17 15:53 agk 2008-01-16 15:25 agk 2007-11-12 13:34 agk 2007-09-24 13:25 wysochanski 2007-09-17 17:18 agk 2006-10-26 18:22 agk 2006-05-24 13:58 agk 2005-06-22 14:56 agk 2004-10-15 15:53 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070717161313.24537.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).