public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: agk@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW lib/datastruct/str_list.c lib ...
Date: Mon, 17 Sep 2007 16:02:00 -0000 [thread overview]
Message-ID: <20070917160247.30018.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk@sourceware.org 2007-09-17 16:02:46
Modified files:
. : WHATS_NEW
lib/datastruct : str_list.c
lib/metadata : metadata.c
Log message:
Fix strdup memory leak in str_list_dup().
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.706&r2=1.707
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/datastruct/str_list.c.diff?cvsroot=lvm2&r1=1.8&r2=1.9
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.135&r2=1.136
--- LVM2/WHATS_NEW 2007/09/12 16:54:23 1.706
+++ LVM2/WHATS_NEW 2007/09/17 16:02:46 1.707
@@ -1,5 +1,6 @@
Version 2.02.29 -
==================================
+ Fix strdup memory leak in str_list_dup().
Avoid static link failure with some SELinux libraries.
Diagnose invalid PE values given on the pvmove command line (64-bit systems).
Include strerror string in dev_open_flags' stat failure message.
--- LVM2/lib/datastruct/str_list.c 2007/08/20 20:55:24 1.8
+++ LVM2/lib/datastruct/str_list.c 2007/09/17 16:02:46 1.9
@@ -74,7 +74,7 @@
list_init(sllnew);
list_iterate_items(sl, sllold) {
- if (!str_list_add(mem, sllnew, strdup(sl->str))) {
+ if (!str_list_add(mem, sllnew, dm_pool_strdup(mem, sl->str))) {
stack;
return 0;
}
--- LVM2/lib/metadata/metadata.c 2007/08/28 16:14:48 1.135
+++ LVM2/lib/metadata/metadata.c 2007/09/17 16:02:46 1.136
@@ -908,6 +908,7 @@
return NULL;
}
+ /* FIXME Can fail when no PV mda */
if (!pv->vg_name[0]) {
log_error("Physical volume %s not in a volume group", pv_name);
return NULL;
next reply other threads:[~2007-09-17 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 16:02 agk [this message]
2012-02-08 12:53 zkabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070917160247.30018.qmail@sourceware.org \
--to=agk@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).