public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvcreate.c Date: Mon, 17 Sep 2007 17:18:00 -0000 [thread overview] Message-ID: <20070917171838.18417.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2007-09-17 17:18:37 Modified files: . : WHATS_NEW tools : lvcreate.c Log message: Remove no-longer-correct restrictions on PV arg count with stripes/mirrors. [E.g. They fail if tags or --alloc anywhere used.] Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.708&r2=1.709 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.144&r2=1.145 --- LVM2/WHATS_NEW 2007/09/17 17:06:31 1.708 +++ LVM2/WHATS_NEW 2007/09/17 17:18:37 1.709 @@ -1,5 +1,6 @@ Version 2.02.29 - ================================== + Remove no-longer-correct restrictions on PV arg count with stripes/mirrors. Fix strdup memory leak in str_list_dup(). Link with -lpthread when static SELinux libraries require that. Detect command line PE values that exceed their 32-bit range. --- LVM2/tools/lvcreate.c 2007/08/30 19:34:19 1.144 +++ LVM2/tools/lvcreate.c 2007/09/17 17:18:37 1.145 @@ -180,10 +180,8 @@ * up to the power of 2) */ static int _read_stripe_params(struct lvcreate_params *lp, struct cmd_context *cmd, - int *pargc) + int *pargc __attribute((unused))) { - int argc = *pargc; - if (arg_count(cmd, stripesize_ARG)) { if (arg_sign_value(cmd, stripesize_ARG, 0) == SIGN_MINUS) { log_error("Negative stripesize is invalid"); @@ -211,12 +209,6 @@ display_size(cmd, (uint64_t) lp->stripe_size)); } - if (argc && (unsigned) argc < lp->stripes) { - log_error("Too few physical volumes on " - "command line for %d-way striping", lp->stripes); - return 0; - } - if (lp->stripes < 1 || lp->stripes > MAX_STRIPES) { log_error("Number of stripes (%d) must be between %d and %d", lp->stripes, 1, MAX_STRIPES); @@ -236,19 +228,12 @@ static int _read_mirror_params(struct lvcreate_params *lp, struct cmd_context *cmd, - int *pargc) + int *pargc __attribute((unused))) { - int argc = *pargc; int region_size; int pagesize = lvm_getpagesize(); const char *mirrorlog; - if (argc && (unsigned) argc < lp->mirrors) { - log_error("Too few physical volumes on " - "command line for %d-way mirroring", lp->mirrors); - return 0; - } - if (arg_count(cmd, regionsize_ARG)) { if (arg_sign_value(cmd, regionsize_ARG, 0) == SIGN_MINUS) { log_error("Negative regionsize is invalid");
next reply other threads:[~2007-09-17 17:18 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-09-17 17:18 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-11 12:33 zkabelac 2012-03-02 17:25 zkabelac 2012-03-01 21:21 zkabelac 2012-02-27 10:00 zkabelac 2011-11-07 11:01 zkabelac 2011-09-22 15:36 jbrassow 2008-09-24 16:32 mbroz 2008-06-05 13:38 agk 2008-01-17 15:53 agk 2008-01-16 15:25 agk 2007-11-12 13:34 agk 2007-09-24 13:25 wysochanski 2007-07-17 16:13 mbroz 2006-10-26 18:22 agk 2006-05-24 13:58 agk 2005-06-22 14:56 agk 2004-10-15 15:53 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070917171838.18417.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).