public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvcreate.c Date: Mon, 24 Sep 2007 13:25:00 -0000 [thread overview] Message-ID: <20070924132532.13191.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2007-09-24 13:25:31 Modified files: . : WHATS_NEW tools : lvcreate.c Log message: Refactor lvcreate stripe parameter validation. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.713&r2=1.714 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.146&r2=1.147 --- LVM2/WHATS_NEW 2007/09/21 18:06:56 1.713 +++ LVM2/WHATS_NEW 2007/09/24 13:25:31 1.714 @@ -1,5 +1,6 @@ Version 2.02.29 - ================================== + Refactor lvcreate stripe and mirror parameter validation. All tools: print --help output to stdout, not stderr. After a diagnostic, suggest --help, rather than printing all --help output. Add %PVS extents option to lvresize, lvextend, and lvcreate. --- LVM2/tools/lvcreate.c 2007/09/20 21:39:08 1.146 +++ LVM2/tools/lvcreate.c 2007/09/24 13:25:31 1.147 @@ -174,28 +174,13 @@ return 1; } -/* The stripe size is limited by the size of a uint32_t, but since the - * value given by the user is doubled, and the final result must be a - * power of 2, we must divide UINT_MAX by four and add 1 (to round it - * up to the power of 2) */ -static int _read_stripe_params(struct lvcreate_params *lp, - struct cmd_context *cmd, - int *pargc __attribute((unused))) +/* + * Generic stripe parameter checks. + * FIXME: Should eventually be moved into lvm library. + */ +static int _validate_stripe_params(struct cmd_context *cmd, + struct lvcreate_params *lp) { - if (arg_count(cmd, stripesize_ARG)) { - if (arg_sign_value(cmd, stripesize_ARG, 0) == SIGN_MINUS) { - log_error("Negative stripesize is invalid"); - return 0; - } - /* Check to make sure we won't overflow lp->stripe_size */ - if(arg_uint_value(cmd, stripesize_ARG, 0) > STRIPE_SIZE_LIMIT) { - log_error("Stripe size cannot be larger than %s", - display_size(cmd, (uint64_t) STRIPE_SIZE_LIMIT)); - return 0; - } - lp->stripe_size = 2 * arg_uint_value(cmd, stripesize_ARG, 0); - } - if (lp->stripes == 1 && lp->stripe_size) { log_print("Ignoring stripesize argument with single stripe"); lp->stripe_size = 0; @@ -226,6 +211,35 @@ return 1; } +/* The stripe size is limited by the size of a uint32_t, but since the + * value given by the user is doubled, and the final result must be a + * power of 2, we must divide UINT_MAX by four and add 1 (to round it + * up to the power of 2) */ +static int _read_stripe_params(struct lvcreate_params *lp, + struct cmd_context *cmd, + int *pargc __attribute((unused))) +{ + if (arg_count(cmd, stripesize_ARG)) { + if (arg_sign_value(cmd, stripesize_ARG, 0) == SIGN_MINUS) { + log_error("Negative stripesize is invalid"); + return 0; + } + /* Check to make sure we won't overflow lp->stripe_size */ + if(arg_uint_value(cmd, stripesize_ARG, 0) > STRIPE_SIZE_LIMIT) { + log_error("Stripe size cannot be larger than %s", + display_size(cmd, (uint64_t) STRIPE_SIZE_LIMIT)); + return 0; + } + lp->stripe_size = 2 * arg_uint_value(cmd, stripesize_ARG, 0); + } + + + if (!_validate_stripe_params(cmd, lp)) + return 0; + + return 1; +} + static int _read_mirror_params(struct lvcreate_params *lp, struct cmd_context *cmd, int *pargc __attribute((unused)))
next reply other threads:[~2007-09-24 13:25 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-09-24 13:25 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-11 12:33 zkabelac 2012-03-02 17:25 zkabelac 2012-03-01 21:21 zkabelac 2012-02-27 10:00 zkabelac 2011-11-07 11:01 zkabelac 2011-09-22 15:36 jbrassow 2008-09-24 16:32 mbroz 2008-06-05 13:38 agk 2008-01-17 15:53 agk 2008-01-16 15:25 agk 2007-11-12 13:34 agk 2007-09-17 17:18 agk 2007-07-17 16:13 mbroz 2006-10-26 18:22 agk 2006-05-24 13:58 agk 2005-06-22 14:56 agk 2004-10-15 15:53 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070924132532.13191.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).