From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-1109-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 23340 invoked by alias); 12 Oct 2007 21:08:39 -0000
Received: (qmail 23326 invoked by uid 9657); 12 Oct 2007 21:08:39 -0000
Date: Fri, 12 Oct 2007 21:08:00 -0000
Message-ID: <20071012210839.23324.qmail@sourceware.org>
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib/metadata metadata.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00014.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2007-10-12 21:08:38

Modified files:
	lib/metadata   : metadata.c 

Log message:
	Remove comment about allocation of pv->vg_name.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.139&r2=1.140

--- LVM2/lib/metadata/metadata.c	2007/10/12 18:37:19	1.139
+++ LVM2/lib/metadata/metadata.c	2007/10/12 21:08:38	1.140
@@ -710,12 +710,6 @@
 
 static void _free_pv(struct dm_pool *mem, struct physical_volume *pv)
 {
-	/*
-	 * FIXME: leak pv->vg_name
-	 * Adding dm_pool_free(mem, pv->vg_name) - causes warning w/'const'
-	 * Perhaps pv->vg_name should be initialized to ORPHAN, not alloc'd
-	 * memory?
-	 */
 	dm_pool_free(mem, pv);
 }