From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-1178-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 18265 invoked by alias); 9 Jan 2008 15:55:45 -0000
Received: (qmail 18250 invoked by uid 9699); 9 Jan 2008 15:55:45 -0000
Date: Wed, 09 Jan 2008 15:55:00 -0000
Message-ID: <20080109155545.18248.qmail@sourceware.org>
From: mornfall@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW tools/lvmcmdline.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2008-01/txt/msg00011.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mornfall@sourceware.org	2008-01-09 15:55:44

Modified files:
	.              : WHATS_NEW 
	tools          : lvmcmdline.c 

Log message:
	Print warning when lvm tools are running as non-root.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.754&r2=1.755
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvmcmdline.c.diff?cvsroot=lvm2&r1=1.56&r2=1.57

--- LVM2/WHATS_NEW	2008/01/09 15:32:18	1.754
+++ LVM2/WHATS_NEW	2008/01/09 15:55:44	1.755
@@ -1,5 +1,6 @@
 Version 2.02.30 -
 ===================================
+  Print warning when lvm tools are running as non-root.
   Add snapshot dmeventd library (enables dmeventd snapshot monitoring).
   Prevent pvcreate from overwriting MDA-less PVs belonging to active VGs.
   Fix a segfault if using pvs with --all argument. (2.02.29)
--- LVM2/tools/lvmcmdline.c	2007/11/15 21:59:11	1.56
+++ LVM2/tools/lvmcmdline.c	2008/01/09 15:55:44	1.57
@@ -1140,6 +1140,12 @@
 	log_sys_error("execvp", path);
 }
 
+static void _nonroot_warning()
+{
+	if (getuid() || geteuid())
+		log_warn("WARNING: Running as a non-root user. Functionality may be unavailable.");
+}
+
 int lvm2_main(int argc, char **argv, unsigned is_static)
 {
 	char *base;
@@ -1186,6 +1192,7 @@
 	}
 #ifdef READLINE_SUPPORT
 	if (!alias && argc == 1) {
+		_nonroot_warning();
 		ret = lvm_shell(cmd, &_cmdline);
 		goto out;
 	}
@@ -1203,6 +1210,7 @@
 		argv++;
 	}
 
+	_nonroot_warning();
 	ret = lvm_run_command(cmd, argc, argv);
 	if ((ret == ENO_SUCH_CMD) && (!alias))
 		ret = _run_script(cmd, argc, argv);